mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
Cesium draw: a material or quad drawing a blob keeps it alive
An image material loads its image on its first draw, and an atlas slot given a new image no longer holds the old blob, so a hidden fill, pattern or quad built from a slot could lose its blob to collection, its URL revoked, before it was ever drawn. Each material built from a blob (shape and ground image fills, line patterns) and each quad now holds the blob it draws while it lives.
This commit is contained in:
1 parent
151230f5fa
commit
2a1e2d9c0b
4 files changed
+123
-10
No files matched your search
@@ -8169,3 +8169,83 @@ test('image fills pulse their alpha through their material, clamped or not', ()
|
||||
);
|
||||
set.dispose();
|
||||
}));
|
||||
|
||||
test('a material drawing a blob from an atlas slot keeps that blob alive after the slot changes', async () => {
|
||||
const v8 = await import('node:v8');
|
||||
const vm = await import('node:vm');
|
||||
v8.setFlagsFromString('--expose-gc');
|
||||
const gc = vm.runInNewContext('gc');
|
||||
const create = URL.createObjectURL;
|
||||
URL.createObjectURL = () => `blob:test/${Math.random()}`;
|
||||
const names = [
|
||||
'HTMLCanvasElement',
|
||||
'HTMLImageElement',
|
||||
'ImageBitmap',
|
||||
'OffscreenCanvas',
|
||||
];
|
||||
const real = names.map((name) => globalThis[name]);
|
||||
for (const name of names) globalThis[name] ??= class {};
|
||||
try {
|
||||
const scene = fakeScene();
|
||||
const part = createCesiumDraw({
|
||||
scene,
|
||||
report: (error) => assert.fail(error),
|
||||
});
|
||||
const refs = {};
|
||||
// Made in a function of their own, so nothing here holds the blobs.
|
||||
(() => {
|
||||
const fillBlob = new Blob(['fill']);
|
||||
const lineBlob = new Blob(['line']);
|
||||
refs.fill = new WeakRef(fillBlob);
|
||||
refs.line = new WeakRef(lineBlob);
|
||||
part.port.atlas('pics', {
|
||||
fill: { blob: fillBlob },
|
||||
line: { blob: lineBlob },
|
||||
});
|
||||
})();
|
||||
const shapes = part.port.shapes({ id: 'blob-fills' });
|
||||
shapes.set([
|
||||
{
|
||||
id: 'image',
|
||||
geometry: {
|
||||
kind: 'rectangle',
|
||||
rect: { west: 2, south: 1, east: 2.1, north: 1.1 },
|
||||
height: 200,
|
||||
},
|
||||
fill: { image: { atlas: 'pics', slot: 'fill' } },
|
||||
},
|
||||
]);
|
||||
const lines = part.port.lines({ id: 'blob-lines' });
|
||||
lines.set([
|
||||
{
|
||||
id: 'pattern',
|
||||
positions: [
|
||||
{ lon: 0, lat: 0, height: 10 },
|
||||
{ lon: 1, lat: 1, height: 10 },
|
||||
],
|
||||
widthPx: 2,
|
||||
style: {
|
||||
kind: 'pattern',
|
||||
image: { atlas: 'pics', slot: 'line' },
|
||||
repeat: 2,
|
||||
},
|
||||
},
|
||||
]);
|
||||
// The slots move on: nothing in the atlas holds the first blobs now.
|
||||
part.port.atlas('pics', {
|
||||
fill: { blob: new Blob(['b']) },
|
||||
line: { blob: new Blob(['c']) },
|
||||
});
|
||||
for (let i = 0; i < 3; i++) {
|
||||
await new Promise((resolve) => setImmediate(resolve));
|
||||
gc();
|
||||
}
|
||||
assert.ok(refs.fill.deref(), 'the fill’s material still has its blob');
|
||||
assert.ok(refs.line.deref(), 'the pattern’s material still has its blob');
|
||||
shapes.dispose();
|
||||
lines.dispose();
|
||||
} finally {
|
||||
URL.createObjectURL = create;
|
||||
names.forEach((name, i) => (globalThis[name] = real[i]));
|
||||
}
|
||||
});
|
||||
Reference in new issue
Block a user