benmichael/gods-eye-view
1
0 Fork 0
mirror of https://github.com/bilawalsidhu/gods-eye-view.git synced 2026-11-05 02:44:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sky): preserve dark model lighting and address review

Browse Source 
Merge origin/main and retain both format-scope additions.
Give StarrySky a separate black environment cube map and release it on destroy.
Guard anime updates when StarrySky is absent, require a visible Normal sky
before anime QA, and compare a lit airplane against black and white controls.
Document the sky background contract and its verification.

Co-Authored-By: GPT-6 (Codex) <[email protected]>
This commit is contained in:
German KhokhlovandGPT-6 committed 2026-10-21 14:21:14 +04:00
2 parents 8c33c6f349 713285b554
commit 27d4c0ba9c
228 files changed
+26920 -17345
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/ui/visualEffects.js
+4 -1
View File
@@ -114,7 +114,10 @@ export class VisualEffects {
stage.enabled = value > 0.001;
// Anime's bands turn the faint Milky Way into blotches, and depth cannot
// tell the sky from far geometry, so the glow fades with the style.
if (stage === this.stages.anime)
if (
stage === this.stages.anime &&
this.viewer.scene.skyBox?.milkyWayVisibility !== undefined
)
this.viewer.scene.skyBox.milkyWayVisibility = 1 - value;
if (stage.enabled && stage.uniforms.time !== undefined)
this.startAnimationLoop();