From 25af56c5a45cfcaff6a9c70b738dceb5242c28d8 Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Mon, 9 Nov 2026 00:56:43 -0800 Subject: [PATCH] Read draw-port picks and the new frame pass in the transit QA The frame-pass source check ended at the old occluder and so scanned the rest of the file; it now ends where the frame pass does. A draw-port pick carries {set, id, meta}, so the sprite's pick is compared by its id. --- scripts/qa-transit.mjs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/qa-transit.mjs b/scripts/qa-transit.mjs index 87fadd842..c1d89fabe 100644 --- a/scripts/qa-transit.mjs +++ b/scripts/qa-transit.mjs @@ -98,7 +98,7 @@ const renderingSource = await readFile( ); const frameSource = renderingSource .split('function onPreRender()')[1] - .split('const occluder')[0]; + .split('const candidatePosition')[0]; check( 'frame pass does not scan the fleet or copy the moving set', !/_vehicles\.values|\[\.\.\.state\._moving\]/.test(frameSource), @@ -1609,7 +1609,8 @@ try { key: entry.key, x, y, - pickKey: picked?.id ?? picked?.primitive?.id ?? null, + // A draw-port pick carries {set, id, meta}; the vehicle is its id. + pickKey: picked?.id?.id ?? picked?.id ?? picked?.primitive?.id ?? null, }; }); let anchor = null;