From 24731951a0c6438173fa768c25faedd1018d65d5 Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Wed, 18 Nov 2026 13:00:41 -0800 Subject: [PATCH] Fly a looked-up place by its coordinates alone, and adopt the bar's files A place row sent its name with its coordinates, and a name that matches a city preset wins over them: "Paris, Texas" flew to Paris, France. Only the coordinates go now. The bar's styles and dock tests join the format scope and the bar its package. Co-authored-by: Manjunath Paparaju --- scripts/format-scope.json | 5 ++++- scripts/package-boundaries.json | 21 +++++++++++++++++++-- src/ui/views/panels/Omnibar.vue | 13 +++++++++---- 3 files changed, 32 insertions(+), 7 deletions(-) diff --git a/scripts/format-scope.json b/scripts/format-scope.json index ae4431aa6e..0e353a030a 100644 --- a/scripts/format-scope.json +++ b/scripts/format-scope.json @@ -1588,5 +1588,8 @@ "scripts/wikidataPlaceTiles.mjs", "src/tooling/wikidataPlaceTiles.test.mjs", "src/ui/omnibarIntent.test.mjs", - "src/ui/omnibarRows.test.mjs" + "src/ui/omnibarRows.test.mjs", + "src/ui/styles/omnibar-dock.css", + "src/ui/styles/guide.css", + "src/ui/commandDock.test.mjs" ] diff --git a/scripts/package-boundaries.json b/scripts/package-boundaries.json index a09757f481..9c3c766101 100644 --- a/scripts/package-boundaries.json +++ b/scripts/package-boundaries.json @@ -289,7 +289,23 @@ "src/render/modelParts.js", "src/ui/views/panels/AircraftModelHero.vue", "src/data/retryableLoad.js", - "src/data/local_data/wikidata_places/files.js" + "src/data/local_data/wikidata_places/files.js", + "src/ui/views/panels/Omnibar.vue", + "src/exclusiveSurfaces.js", + "src/geoDistance.js", + "src/ui/omnibarGuide.js", + "src/cityPois.js", + "src/search/photonSetting.js", + "src/sources/requestDeadline.js", + "src/ui/omnibarEnter.js", + "src/ui/omnibarIntent.js", + "src/data/placeNames.js", + "src/search/plusCode.js", + "src/keylessGeocoder.js", + "src/ui/omnibarRows.js", + "src/search/gridReference.js", + "src/search/coordinateParser.js", + "src/search/placeSuggestions.js" ], "external": ["vue", "pinia", "vue-i18n"] }, @@ -1657,7 +1673,8 @@ "src/ui/entityContextBridge.js", "src/data/trackingClickGesture.js", "src/ui/stores/sceneSharing.js", - "src/maps/attribution.js" + "src/maps/attribution.js", + "src/data/dataCredits.js" ], "external": [ "cesium", diff --git a/src/ui/views/panels/Omnibar.vue b/src/ui/views/panels/Omnibar.vue index 1b4479a6c9..fa4f6f3afd 100644 --- a/src/ui/views/panels/Omnibar.vue +++ b/src/ui/views/panels/Omnibar.vue @@ -372,9 +372,13 @@ const strip = computed(() => { return all.length ? { title, chips: all } : null; }); -/** Fly to a place by its coordinates, as a looked-up place row does. */ -async function goTo({ name, latitude, longitude }) { - if (runner.value) return settled(await runner.value('fly_to_location', { latitude, longitude, query: name })); +/** + * Fly to a place by its coordinates, as a looked-up place row does. Only the + * coordinates go: with its name, "Paris, Texas" would fly to the city + * preset Paris. + */ +async function goTo({ latitude, longitude }) { + if (runner.value) return settled(await runner.value('fly_to_location', { latitude, longitude })); const location = locationStore.controls; if (!location || location.destroyed) throw new Error(); await location.search(`${latitude}, ${longitude}`); @@ -820,7 +824,8 @@ async function choose(item, { viaKey = false } = {}) { else if (item.kind === 'count-show' || item.kind === 'place') { const { coords, place } = item; if (coords && runner.value) { - if (!settled(await runner.value('fly_to_location', { ...coords, query: place }))) return; + // The coordinates alone: a name would win over them (see goTo). + if (!settled(await runner.value('fly_to_location', { ...coords }))) return; } else { const location = locationStore.controls; if (!location || location.destroyed) throw new Error();