mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-22 03:02:20 +00:00
Build test engines from the shared fake instead of literals
Tests that made their own engine object now use createFakeEngine() with its scripting hooks or an override of the one member under test, so they follow the contract when it changes. 125 such literals in 74 test files go down to two that are not globe engines on purpose; report-qa-harness counts them, and the baseline keeps the number from growing.
This commit is contained in:
1 parent
3c304502a0
commit
225c1c25c7
76 files changed
+668
-564
No files matched your search
@@ -1,3 +1,4 @@
|
||||
import { createFakeEngine } from '../globe/testing/fakeEngine.js';
|
||||
// Pure-logic unit tests for the voice-lifecycle size guards (Batch 11, M13).
|
||||
// These helpers are DOM/WebRTC-free so they pin the screenshot down-scaling and
|
||||
// payload-byte estimation that keep an oversized dc.send from stranding a turn.
|
||||
@@ -2859,10 +2860,8 @@ test('isBenignViewportDeleteError is false for non-error payloads and junk', ()
|
||||
test('hidden document yields no fresh frame — capture must not label a stale canvas Current', async () => {
|
||||
const originalDocument = globalThis.document;
|
||||
let requested = 0;
|
||||
const engine = {
|
||||
frames: { postRender: { addEventListener() { return () => {}; } } },
|
||||
render: { request() { requested += 1; } },
|
||||
};
|
||||
const engine = createFakeEngine();
|
||||
engine.render.request = () => { requested += 1; };
|
||||
try {
|
||||
globalThis.document = { hidden: true };
|
||||
const fresh = await renderFreshCesiumFrame(engine);
|
||||
@@ -2878,10 +2877,9 @@ test('visible document with a rendering scene reports a fresh frame', async () =
|
||||
try {
|
||||
globalThis.document = { hidden: false };
|
||||
let fire = null;
|
||||
const engine = {
|
||||
frames: { postRender: { addEventListener(listener) { fire = listener; return () => { fire = null; }; } } },
|
||||
render: { request() { queueMicrotask(() => fire?.()); } },
|
||||
};
|
||||
const engine = createFakeEngine();
|
||||
engine.frames.postRender.addEventListener = (listener) => { fire = listener; return () => { fire = null; }; };
|
||||
engine.render.request = () => { queueMicrotask(() => fire?.()); };
|
||||
const fresh = await renderFreshCesiumFrame(engine);
|
||||
assert.equal(fresh, true);
|
||||
} finally {
|
||||
@@ -2895,10 +2893,9 @@ test('a tab switch during the bounded render wait invalidates freshness', async
|
||||
const doc = { hidden: false };
|
||||
globalThis.document = doc;
|
||||
let fire = null;
|
||||
const engine = {
|
||||
frames: { postRender: { addEventListener(listener) { fire = listener; return () => { fire = null; }; } } },
|
||||
render: { request() { doc.hidden = true; queueMicrotask(() => fire?.()); } },
|
||||
};
|
||||
const engine = createFakeEngine();
|
||||
engine.frames.postRender.addEventListener = (listener) => { fire = listener; return () => { fire = null; }; };
|
||||
engine.render.request = () => { doc.hidden = true; queueMicrotask(() => fire?.()); };
|
||||
const fresh = await renderFreshCesiumFrame(engine);
|
||||
assert.equal(fresh, false, 'freshness rechecked after the await');
|
||||
} finally {
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
import { createFakeEngine } from '../globe/testing/fakeEngine.js';
|
||||
// Cross-feature voice contracts, driven through the real action runner:
|
||||
// one result contract (engine fields → model payload → voice card), shared
|
||||
// pointing for imagery, result-set ownership between OSM and the analyst,
|
||||
@@ -687,7 +688,7 @@ test('an engine switch keeps the last answer for a follow-up on the next engine'
|
||||
build: () =>
|
||||
harness({ runnerOptions: { analystMemory, layerEnabledAt } }).runner,
|
||||
});
|
||||
run.attach({ engine: { kind: 'cesium' } });
|
||||
run.attach({ engine: createFakeEngine({ kind: 'cesium' }) });
|
||||
const first = await run('analyst_query', {
|
||||
layers: ['flights'],
|
||||
scope: { kind: 'anywhere' },
|
||||
@@ -695,7 +696,7 @@ test('an engine switch keeps the last answer for a follow-up on the next engine'
|
||||
assert.equal(first.ok, true);
|
||||
// The real runner of the outgoing engine is disposed by the switch.
|
||||
run.detach();
|
||||
run.attach({ engine: { kind: 'navara' } });
|
||||
run.attach({ engine: createFakeEngine({ kind: 'navara' }) });
|
||||
const followUp = await run('analyst_query', {
|
||||
layers: ['flights'],
|
||||
followUp: true,
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
import { createFakeEngine } from '../globe/testing/fakeEngine.js';
|
||||
import assert from 'node:assert/strict';
|
||||
import test from 'node:test';
|
||||
import {
|
||||
@@ -96,23 +97,16 @@ test('crop: a slow render gets one bounded fresh-frame recovery request', async
|
||||
let listener = null;
|
||||
try {
|
||||
globalThis.document = { hidden: false };
|
||||
const engine = {
|
||||
frames: {
|
||||
postRender: {
|
||||
addEventListener(next) {
|
||||
listener = next;
|
||||
return () => {
|
||||
if (listener === next) listener = null;
|
||||
};
|
||||
},
|
||||
},
|
||||
},
|
||||
render: {
|
||||
request() {
|
||||
requests += 1;
|
||||
if (requests === 2) queueMicrotask(() => listener?.());
|
||||
},
|
||||
},
|
||||
const engine = createFakeEngine();
|
||||
engine.frames.postRender.addEventListener = (next) => {
|
||||
listener = next;
|
||||
return () => {
|
||||
if (listener === next) listener = null;
|
||||
};
|
||||
};
|
||||
engine.render.request = () => {
|
||||
requests += 1;
|
||||
if (requests === 2) queueMicrotask(() => listener?.());
|
||||
};
|
||||
assert.equal(await renderFreshPointerFrame(engine), true);
|
||||
assert.equal(requests, 2, 'only the pointer path retries once');
|
||||
@@ -127,13 +121,9 @@ test('crop: a hidden document never starts the recovery request', async () => {
|
||||
let requests = 0;
|
||||
try {
|
||||
globalThis.document = { hidden: true };
|
||||
const engine = {
|
||||
frames: { postRender: { addEventListener: () => () => {} } },
|
||||
render: {
|
||||
request() {
|
||||
requests += 1;
|
||||
},
|
||||
},
|
||||
const engine = createFakeEngine();
|
||||
engine.render.request = () => {
|
||||
requests += 1;
|
||||
};
|
||||
assert.equal(await renderFreshPointerFrame(engine), false);
|
||||
assert.equal(requests, 0);
|
||||
|
||||
@@ -1,8 +1,9 @@
|
||||
import { createFakeEngine } from '../globe/testing/fakeEngine.js';
|
||||
import test from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { createSceneRunner, engineSwitchingRefusal } from './sceneRunner.js';
|
||||
|
||||
const engine = (kind) => ({ kind });
|
||||
const engine = (kind) => createFakeEngine({ kind });
|
||||
|
||||
function runnerFor(log) {
|
||||
return (scene) => {
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
import { createFakeEngine } from '../globe/testing/fakeEngine.js';
|
||||
import test from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { createSceneVoice } from './gevRealtime.js';
|
||||
@@ -6,11 +7,7 @@ import { createTestVoiceUi } from '../testSupport/voiceUi.mjs';
|
||||
function fakeEngine(kind) {
|
||||
const canvas = new EventTarget();
|
||||
canvas.getBoundingClientRect = () => ({ left: 0, top: 0 });
|
||||
return {
|
||||
kind,
|
||||
host: { canvas, size: () => ({ width: 0, height: 0 }) },
|
||||
camera: { pose: () => ({}) },
|
||||
};
|
||||
return createFakeEngine({ kind, canvas, width: 0, height: 0 });
|
||||
}
|
||||
|
||||
function fixture() {
|
||||
|
||||
Reference in new issue
Block a user