i18n: fix the LGTM review findings and tidy the branch texts

- i18n scanner: lastError sink, no false sinks on defaults and ternaries
- shared src/i18n/marker.js for modules that only mark strings
- wind field messages move to wind/fields.js; CITY_POIS imports from cityPois.js
- drop review IDs, change history and stale references from comments and docs

Co-Authored-By: Claude Opus 5.5 <[email protected]>

src/layers/launches/missionStatus.i18n.test.mjs

@@ -0,0 +1,85 @@
+// A launch without a Launch Library status gets our 'Unknown'. The record keeps
+// it English; the mission panel translates it and shows provider statuses as sent.
+import assert from 'node:assert/strict';
+import test from 'node:test';
+import { setLocale } from '../../i18n/index.js';
+import {
+  launchStatusAllowsOrbit,
+  normalizeRocketLaunches,
+} from '../../data/rocketLaunches.js';
+import { UNKNOWN_LAUNCH_STATUS } from './model.js';
+import { createPanel } from './panel.js';
+
+const NOW = new Date('2026-07-27T00:00:00Z');
+
+function shownStatus(status) {
+  const outputs = new Map();
+  const state = {
+    _missionPanel: {
+      querySelector(selector) {
+        if (!outputs.has(selector))
+          outputs.set(selector, {
+            textContent: '',
+            closest: () => null,
+            removeAttribute() {},
+          });
+        return outputs.get(selector);
+      },
+      closest: () => null,
+    },
+    _selectedLaunchId: 'mission-1',
+    _launches: [
+      {
+        id: 'mission-1',
+        name: 'Example',
+        status,
+        payloads: [],
+        recoveryStages: [],
+      },
+    ],
+    _replayTracks: new Map(),
+  };
+  createPanel({
+    state,
+    parts: {
+      overlays: { shortMissionLabel: (name) => name },
+      policyHelpers: { missionPathPresentation: () => ({}) },
+      replay: { syncReplayButton() {} },
+    },
+  }).renderMissionPanel();
+  return outputs.get('[data-mission-status]').textContent;
+}
+
+test('a launch without a status keeps the English fallback in its record', () => {
+  const [launch] = normalizeRocketLaunches(
+    {
+      results: [
+        {
+          id: 'no-status',
+          name: 'Test Flight',
+          net: '2026-07-20T10:00:00Z',
+          pad: {
+            name: 'Pad A',
+            location: { name: 'Test Range', coordinates: '12.5,45.5' },
+          },
+        },
+      ],
+    },
+    NOW,
+  );
+  assert.equal(UNKNOWN_LAUNCH_STATUS, 'Unknown');
+  assert.equal(launch.status, 'Unknown');
+  assert.equal(launchStatusAllowsOrbit(launch.status), true);
+});
+
+test('the mission panel translates only the fallback status', (t) => {
+  t.after(() => setLocale('en'));
+  setLocale('en');
+  assert.equal(shownStatus(UNKNOWN_LAUNCH_STATUS), 'Unknown');
+  setLocale('ru');
+  assert.equal(shownStatus(UNKNOWN_LAUNCH_STATUS), 'Неизвестно');
+  assert.equal(shownStatus('Go for Launch'), 'Go for Launch');
+  setLocale('es');
+  assert.equal(shownStatus(UNKNOWN_LAUNCH_STATUS), 'Desconocido');
+  assert.equal(shownStatus('Launch Successful'), 'Launch Successful');
+});

src/layers/launches/model.js

@@ -1,6 +1,13 @@
 import * as Cesium from 'cesium';
+import { msg } from '../../i18n/index.js';
 import { WINDOW_DAYS } from './policy.js';
 
+/**
+ * Fallback when Launch Library sends no status. English in the record
+ * (launchStatusAllowsOrbit, analyst records); the mission panel translates it.
+ */
+export const UNKNOWN_LAUNCH_STATUS = msg('Unknown');
+
 export function createModel({ state: layerState, services, parts, source }) {
   function finiteCoordinate(value) {
     const number = Number(value);
@@ -192,8 +199,7 @@ export function createModel({ state: layerState, services, parts, source }) {
             launch.id || launch.slug || launch.name || `launch-${date}`,
           ),
           name: launch.name || 'Unnamed launch',
-          // i18n-ignore: Launch Library status names are provider data, shown as sent
-          status: launch.status?.name || 'Unknown',
+          status: launch.status?.name || UNKNOWN_LAUNCH_STATUS,
           launchTime: Number.isFinite(date)
             ? new Date(date).toISOString()
             : null,

src/layers/launches/panel.js

@@ -4,6 +4,7 @@ import {
   MISSION_CLOSE_VIEW_RANGE_M,
   MISSION_GLOBE_VIEW_RANGE_M,
 } from './policy.js';
+import { UNKNOWN_LAUNCH_STATUS } from './model.js';
 
 export function createPanel({ state: layerState, services, parts, source }) {
   /**
@@ -191,7 +192,14 @@ export function createPanel({ state: layerState, services, parts, source }) {
     layerState._missionPanel.querySelector('[data-mission-title]').textContent =
       parts.overlays.shortMissionLabel(launch.name, 32).toUpperCase();
     setMissionPanelField('[data-mission-provider]', launch.provider);
-    setMissionPanelField('[data-mission-status]', launch.status);
+    // Launch Library status names are provider data, shown as sent; only the
+    // fallback for a launch without one is ours to translate.
+    setMissionPanelField(
+      '[data-mission-status]',
+      launch.status === UNKNOWN_LAUNCH_STATUS
+        ? t(UNKNOWN_LAUNCH_STATUS)
+        : launch.status,
+    );
     setMissionPanelField(
       '[data-mission-site]',
       launch.launchSite && launch.launchSite !== 'Unknown launch site'