i18n: fix the LGTM review findings and tidy the branch texts

- i18n scanner: lastError sink, no false sinks on defaults and ternaries
- shared src/i18n/marker.js for modules that only mark strings
- wind field messages move to wind/fields.js; CITY_POIS imports from cityPois.js
- drop review IDs, change history and stale references from comments and docs

Co-Authored-By: Claude Opus 5.5 <[email protected]>

src/data/satelliteClass.js

@@ -20,53 +20,43 @@
 import { t, msg } from '../i18n/index.js';
 
 /**
- * Class registry. `label` is the card/legend token, `color` the point color,
- * `blurb` the plain-language gloss for the legend tooltip.
- * @type {Readonly<Record<string, { label: string, color: string, blurb: string }>>}
+ * Class registry: the point color of each class. The card and legend text is
+ * in CLASS_DISPLAY_KEYS.
+ * @type {Readonly<Record<string, { color: string }>>}
  */
 export const SATELLITE_CLASSES = Object.freeze({
   station: Object.freeze({
-    label: 'STATION', // i18n-ignore: English token; shown through CLASS_DISPLAY_KEYS
     // Warm white — "crewed", and the brightest class in the sky. Deliberately
     // NOT amber: 40-48deg amber is the app's known-military convention
     // (flights.js MIL_TINT / militaryFlights.js MIL_ICON_COLOR) and must not
     // leak into another domain. Slightly warm so it also separates from the
     // pure white the civilian air fleet draws in.
     color: '#fff6e5',
-    blurb: 'Crewed stations and their visiting vehicles', // i18n-ignore: shown through CLASS_DISPLAY_KEYS
   }),
   nav: Object.freeze({
-    label: 'NAV', // i18n-ignore: English token; shown through CLASS_DISPLAY_KEYS
     // Cyan — the strongest accent goes to the class users actually name
     // ("how many GPS satellites are up?"). Takes over the slot the catch-all
     // VISUAL group used to occupy, so this adds no new hue to the app.
     color: '#4fd8ff',
-    blurb: 'GNSS navigation — GPS, GLONASS, Galileo', // i18n-ignore: shown through CLASS_DISPLAY_KEYS
   }),
   geo: Object.freeze({
-    label: 'GEO', // i18n-ignore: English token; shown through CLASS_DISPLAY_KEYS
     // Violet, unchanged. Already the app's "space" semantic (the detection
     // overlay paints the SAT tier #bda4ff), and the geostationary belt draws
     // as one clean equatorial ring at globe scale.
     color: '#c89bff',
-    blurb: 'Geostationary belt — comms and weather, fixed over the equator', // i18n-ignore: shown through CLASS_DISPLAY_KEYS
   }),
   visual: Object.freeze({
-    label: 'VISUAL', // i18n-ignore: English token; shown through CLASS_DISPLAY_KEYS
     // Muted blue-gray. This is the catch-all bucket, so it gives up the bright
     // cyan it used to hold and recedes behind the three classes that mean
     // something. Still well clear of the dense shell by luminance.
     color: '#9fb3c4',
-    blurb: 'Brightest naked-eye objects — CelesTrak visual group', // i18n-ignore: shown through CLASS_DISPLAY_KEYS
   }),
   comms: Object.freeze({
-    label: 'COMMS', // i18n-ignore: English token; shown through CLASS_DISPLAY_KEYS
     // Dim slate — thousands of these appear in DENSE mode. They must read as
     // texture behind the core catalog, never compete with it. Rec.601 luma
     // ~0.40 against VISUAL's ~0.69 keeps the two separable even when the
     // NVG/FLIR shaders collapse the scene to a single channel.
     color: '#54697f',
-    blurb: 'Broadband constellation shell — shown only in DENSE mode', // i18n-ignore: shown through CLASS_DISPLAY_KEYS
   }),
 });
 
@@ -79,9 +69,7 @@ export const SATELLITE_CLASS_ORDER = Object.freeze([
   'comms',
 ]);
 
-// Display keys for the class table above: `label`/`blurb` stay the English
-// source-of-truth tokens (tests read them), while the card and legend accessors
-// translate through these keys at the presentation boundary.
+// What the card and legend show for each class.
 const CLASS_DISPLAY_KEYS = Object.freeze({
   station: Object.freeze({
     label: msg('STATION'),
@@ -164,7 +152,8 @@ export function satelliteClassColor(group) {
  * The ISS is always a STATION regardless of which group ingested it — see
  * satelliteClassOf, which owns that rule for every consumer.
  * @param {string|undefined|null} group CelesTrak group tag.
- * @param {{ isIss?: boolean }} [options] Whether this is the ISS.
+ * @param {{ isIss?: boolean, localize?: boolean }} [options] isIss: the ISS;
+ *   localize: false keeps the English label (data for the AI tools).
  * @returns {string} Display label.
  */
 export function satelliteClassLabel(
@@ -172,7 +161,6 @@ export function satelliteClassLabel(
   { isIss = false, localize = true } = {},
 ) {
   const { klass, subtype } = satelliteClassOf(group, { isIss });
-  // localize: false keeps the English label for data the AI tools query.
   const label = CLASS_DISPLAY_KEYS[klass].label;
   const base = localize ? t(label) : label;
   return subtype ? `${base} · ${subtype}` : base;