mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
fix(voice): resolve areas per view, without accents and per natural place
From review:
- An answer the view picked ("Springfield" over Illinois) is reused or
shared only within the same ~2° view cell, so asking again elsewhere no
longer gets the first state's area.
- Admin names compare with accents folded on Latin letters only: "Quebec"
matches "Québec" and "Cordoba" asks between Argentina and Spain, while a
Thai or Devanagari mark still tells names apart.
- A Natural Earth name used by several features is one place with every
part when they touch (the Great Rift Valley, the Lau Group across 180°)
and a question when they are far apart (Flores); natural places can now
be candidates.
- The AREAS rule and the area tool descriptions are tighter, leaving a
~270-character margin under the 55,500 prompt ceiling, and resolve_area
no longer names osm_query when that tool is not offered.
This commit is contained in:
1 parent
fb74354d30
commit
207373389a
12 files changed
+328
-22
No files matched your search
@@ -695,6 +695,11 @@ test('boundaries route to resolve_area; annotate_map is for marks', () => {
|
||||
test('without an operator Overpass the prompt never offers place search', () => {
|
||||
const plain = realtimeInstructions();
|
||||
assert.doesNotMatch(plain, /osm_query/);
|
||||
assert.doesNotMatch(
|
||||
JSON.stringify(realtimeTools()),
|
||||
/osm_query/,
|
||||
'no other tool description points at it either',
|
||||
);
|
||||
assert.equal(
|
||||
realtimeTools().some((tool) => tool.name === 'osm_query'),
|
||||
false,
|
||||
|
||||
Reference in new issue
Block a user