mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-05 10:53:59 +00:00
fix: separate Google browser and server keys (#110)
Use a separate optional server key for Places and Street View, with consistent local and Pinokio configuration, server-first CLI selection, and credential isolation checks. Original contribution by Tom-Neverwinter; reviewed and completed by Sameh Khamis. Co-authored-by: Tom-Neverwinter <[email protected]> Co-authored-by: Sameh Khamis <[email protected]>
This commit is contained in:
1 parent
e9b6214ec4
commit
205c58efbd
21 files changed
+282
-28
No files matched your search
@@ -19,6 +19,7 @@ function encodeUtf16be(source) {
|
||||
|
||||
const PROVIDER_FIELDS = [
|
||||
'GOOGLE_MAPS_API_KEY',
|
||||
'GOOGLE_MAPS_SERVER_API_KEY',
|
||||
'CESIUM_ION_TOKEN',
|
||||
'OPENAI_API_KEY',
|
||||
'AISSTREAM_API_KEY',
|
||||
@@ -206,3 +207,22 @@ for (const fixture of [
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
test('server Google key follows app values, blanks and absence instead of inherited credentials', () => {
|
||||
const root = mkdtempSync(path.join(tmpdir(), 'gev-pinokio-server-key-'));
|
||||
try {
|
||||
const filepath = path.join(root, 'ENVIRONMENT');
|
||||
for (const [source, expected] of [
|
||||
['GOOGLE_MAPS_SERVER_API_KEY=app-server\n', 'app-server'],
|
||||
['GOOGLE_MAPS_SERVER_API_KEY=\n', ''],
|
||||
['', ''],
|
||||
]) {
|
||||
writeFileSync(filepath, source);
|
||||
const environment = { GOOGLE_MAPS_SERVER_API_KEY: 'global-server' };
|
||||
applyPinokioEnvironment({ environment, filepath });
|
||||
assert.equal(environment.GOOGLE_MAPS_SERVER_API_KEY, expected);
|
||||
}
|
||||
} finally {
|
||||
rmSync(root, { recursive: true, force: true });
|
||||
}
|
||||
});
|
||||
Reference in new issue
Block a user