Fly the remaining flights through the camera port, on any viewer

The embed view, the celestial-ring focus, the ground-guard lift, the
Bhote Koshi approach and orbit, launch selection and replay flights, and
the cockpit's view and takeover now drive the renderer's camera port.
The contract gains a sineInOut easing, pinned by a conformance trace.

A viewer with no renderer bound, such as one a caller of a public
export brings, now gets a camera port too, as it already got an input
port: cameraOf builds one over the viewer's own Cesium camera and keeps
it for the viewer's life, until a renderer is bound. The Cesium adapter
provides the factory as it loads; code that reaches Cesium takes cameraOf
from the adapter so the factory comes with it, and findCamera answers
null where a missing camera is not an error (HUD, share link, world
focus, Recent Imagery's ZOOM IN). A test walks every package export and
fails one that can reach the bridge without loading the factory.

A destroyed viewer gets no camera and lets go of a built one, and the
application renderer stays bound until its viewer is destroyed.
This commit is contained in:
Sameh Khamis committed 2026-11-06 08:21:57 -08:00
1 parent c5b716b107
commit 1d4e4ebe90
44 files changed
+1167 -344

No files matched your search

+56 -1
View File
@@ -1,6 +1,12 @@
import assert from 'node:assert/strict';
import test from 'node:test';
import { bindRenderer, cameraOf, rendererOf } from './rendererOf.js';
import {
bindRenderer,
cameraOf,
findCamera,
provideUnboundCamera,
rendererOf,
} from './rendererOf.js';
test('a scene finds its renderer until it is unbound', () => {
const scene = {};
@@ -32,3 +38,52 @@ test('cameraOf names the missing renderer instead of returning nothing', () => {
assert.equal(cameraOf(scene), camera);
unbind();
});
test('with no renderer bound, cameraOf builds one camera per scene until a renderer is bound', (t) => {
t.after(() => provideUnboundCamera(null));
const built = [];
provideUnboundCamera((host) => {
if (!host.camera) return null;
const entry = { port: { id: built.length }, disposed: 0 };
entry.dispose = () => (entry.disposed += 1);
built.push(entry);
return entry;
});
const viewer = { camera: {} };
assert.equal(cameraOf(viewer), built[0].port);
assert.equal(cameraOf(viewer), built[0].port, 'kept, not rebuilt');
assert.equal(built.length, 1);
assert.throws(
() => cameraOf({}),
/no renderer camera/,
'nothing to build over',
);
assert.equal(findCamera({}), null);
assert.equal(findCamera(null), null);
const camera = { pose() {} };
const unbind = bindRenderer(viewer, { camera });
assert.equal(
built[0].disposed,
1,
'the renderer supersedes the built camera',
);
assert.equal(cameraOf(viewer), camera);
unbind();
assert.equal(cameraOf(viewer), built[1].port, 'unbound again: a fresh one');
});
test('a destroyed scene gets no built camera, and lets go of the one it had', (t) => {
t.after(() => provideUnboundCamera(null));
let disposed = 0;
provideUnboundCamera(() => ({ port: {}, dispose: () => (disposed += 1) }));
let destroyed = false;
const viewer = { isDestroyed: () => destroyed };
cameraOf(viewer);
destroyed = true;
assert.throws(() => cameraOf(viewer), /destroyed/);
assert.equal(disposed, 1);
assert.equal(findCamera(viewer), null, 'findCamera answers null instead');
assert.throws(() => cameraOf(viewer), /destroyed/);
assert.equal(disposed, 1, 'once');
});