mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
Tidy the vessels layer on the draw port: shared pose key, lazy pose, frame reasons, sprite order
The camera pose key moves to render/camera/poseSignature.js, Cesium-free, and iconOrientation's cameraPoseSignature builds the same key through it. The vessels frame hook reads the pose only when a pass runs or a moved camera could still need its trailing pass, and the unused focus scratch point goes. The draw port takes the frame port's requestRender, so a GPU icon set's own frames (its images packed into the atlas) are asked for under the reason icons:<set id> in the frame diagnostics, where the vessels layer's own ais-vessels-icons reason used to be. Other draw requests are unchanged. A host with no registerSpriteSet still draws the ships and warns once. The vessels draw test now checks the sprite order finds the set's host, and that a torn-down layer draws a new set registered in the old one's place. The new motion, icon book and pose key tests join the format check.
This commit is contained in:
1 parent
7a9c7b4d96
commit
1c8cf240c4
14 files changed
+334
-76
No files matched your search
@@ -10,7 +10,7 @@ import { bindFakeCesiumScene } from '../../testSupport/fakeCesiumScene.mjs';
|
||||
|
||||
const noop = () => {};
|
||||
|
||||
function setup() {
|
||||
function setup({ focusPassIsNeeded = () => false } = {}) {
|
||||
let clock = 10_000;
|
||||
const requests = [];
|
||||
const holds = new Set();
|
||||
@@ -34,11 +34,11 @@ function setup() {
|
||||
clearOverlaySource: noop,
|
||||
},
|
||||
geoid: {},
|
||||
sprites: {},
|
||||
sprites: { registerSpriteSet: noop },
|
||||
focus: {
|
||||
focusNowMs: () => clock,
|
||||
getFocusTarget: () => null,
|
||||
focusPassIsNeeded: () => false,
|
||||
focusPassIsNeeded,
|
||||
forgetSpriteFocus: noop,
|
||||
},
|
||||
worldFocus: {},
|
||||
@@ -139,3 +139,48 @@ test('destroy cancels a pending trailing frame', (t) => {
|
||||
advance(VISIBILITY_UPDATE_MS);
|
||||
assert.deepEqual(requests, []);
|
||||
});
|
||||
|
||||
test('frames inside the cadence with a trailing frame waiting read no camera pose', () => {
|
||||
const { camera, timers, advance, frame } = setup();
|
||||
let reads = 0;
|
||||
const position = camera.positionWC;
|
||||
Object.defineProperty(camera, 'positionWC', {
|
||||
get: () => (reads++, position),
|
||||
});
|
||||
frame();
|
||||
assert.ok(reads > 0, 'the cadence pass reads it');
|
||||
advance(100);
|
||||
camera.heading = 0.5;
|
||||
reads = 0;
|
||||
frame();
|
||||
assert.ok(reads > 0, 'a skipped frame reads it to see the camera moved');
|
||||
assert.equal(timers.size, 1);
|
||||
reads = 0;
|
||||
for (let i = 0; i < 5; i += 1) {
|
||||
advance(100);
|
||||
frame();
|
||||
}
|
||||
assert.equal(reads, 0, 'the trailing frame already waits');
|
||||
});
|
||||
|
||||
test('a focus pass reads the camera pose even with a trailing frame waiting', () => {
|
||||
let focusing = false;
|
||||
const { camera, timers, advance, frame } = setup({
|
||||
focusPassIsNeeded: () => focusing,
|
||||
});
|
||||
let reads = 0;
|
||||
const position = camera.positionWC;
|
||||
Object.defineProperty(camera, 'positionWC', {
|
||||
get: () => (reads++, position),
|
||||
});
|
||||
frame();
|
||||
advance(100);
|
||||
camera.heading = 0.5;
|
||||
frame();
|
||||
assert.equal(timers.size, 1);
|
||||
focusing = true;
|
||||
reads = 0;
|
||||
advance(100);
|
||||
frame();
|
||||
assert.ok(reads > 0, 'the focus pass needs the eye');
|
||||
});
|
||||
Reference in new issue
Block a user