mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
Show the renderer's credits in the application's own line
- On a renderer whose plugin does not show its credits in a display of its own (the ownCreditDisplay hook; Cesium's does), the application shows what the credits port lists at the bottom left (#gev-credits): inline credits on the line, the rest, the layers' data credits among them, in the Data attribution list it opens. The button and list are keyboard operable; Escape closes the list and returns focus. Text is set as text; links and logos keep only safe schemes. - The panel, Cockpit and overlay layouts keep clear of it as of Cesium's. - The stub boot check fails when the credits line is not shown or its list is empty; it keeps its report when the run stops early, counts only the dev server's providers and other origins as feeds, and a failed default renderer load is retried without dropping a newer one.
This commit is contained in:
1 parent
691cb0cd79
commit
16c7034c28
15 files changed
+411
-18
No files matched your search
@@ -217,7 +217,10 @@ on (no `renderer.id`, no engine type, no engine object's presence).
|
||||
`provideApplicationHooks(renderer, hooks)` (`src/render/applicationHooks.js`),
|
||||
each hook optional and used only where given: a map engine of its own,
|
||||
stale command trimming, inline panel rendering, whether an entity is its
|
||||
own, the zoom-out guard, and what QA scripts read from
|
||||
own, the zoom-out guard, whether it shows its credits in a display of
|
||||
its own (`ownCreditDisplay`; otherwise the application's own line,
|
||||
`src/ui/creditsView.js`, shows the credits port's list), and what QA
|
||||
scripts read from
|
||||
`window.__godsEyeView` (Cesium's viewer there, for the scripts that drive
|
||||
it). None is a contract member, and a renderer without them runs the
|
||||
application without that behaviour.
|
||||
@@ -227,7 +230,8 @@ on (no `renderer.id`, no engine type, no engine object's presence).
|
||||
- **The proof.** `npm run qa:stub-boot` (`scripts/qa-stub-boot.mjs`) serves
|
||||
the application's page with `dev/stub-app/main.js` as its entry: the whole
|
||||
application on the stub with no capability at all. It fails when the page
|
||||
requests any Cesium module or asset, on a page or console error, or when a
|
||||
requests any Cesium module or asset, when the credits line is not shown
|
||||
with its data credits, on a page or console error, or when a
|
||||
data layer (flights, transit, traffic, CCTV, vessels, weather, wind,
|
||||
satellites, FIRMS, wildlife) fails to turn on or off; `--strict` also fails
|
||||
a layer that draws nothing on the stub (it needs the live feeds).
|
||||
|
||||
Reference in new issue
Block a user