mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-18 17:22:19 +00:00
Tidy the Cockpit subject camera and HUD fixes after review
- A provider's look, height and speed are read once, so a getter that answers once is not lost; a Promise in a provider's words is refused and its rejection handled. - A huge heading slew rate is capped at a half turn per step instead of overflowing to Infinity. - A row changed in place keeps the time it first appeared; JSDoc, CURRENT-STATE and the ETA test say so. - APPLICATION.md says the app page must load the entry icon's glyph. - Tests check that entry succeeds, the vessel bridge is entered, a floor takes over from the entry height (also at 0 m), and share helpers; the provider unit test moves to the provider tests. - WIDE_GLYPH uses escapes; comments, the release notes and CURRENT-STATE match the code.
This commit is contained in:
1 parent
a72c0ba237
commit
109bb0fd4f
14 files changed
+279
-163
No files matched your search
+3
-2
@@ -396,8 +396,9 @@ their `this`; one that throws or returns a promise is treated as having
|
||||
failed. What a method returns may carry getters: one that throws when read
|
||||
makes a candidate none, a frame malformed (the view ends) and a HUD view keep
|
||||
the last; a worded member (labels, entry face, look) that throws keeps its
|
||||
last good words. An entry face's `icon` must be one of the Material Symbols
|
||||
`index.html` loads (`icon_names`); any other renders as its name.
|
||||
last good words. An entry face's `icon` is a Material Symbols name whose glyph
|
||||
the application's page must load (GEV's own `index.html` loads a subset, its
|
||||
`icon_names`); a glyph the page does not load renders as its name.
|
||||
|
||||
```js
|
||||
import { getLocale, onLocaleChange } from 'gods-eye-view/i18n';
|
||||
|
||||
+13
-14
@@ -2743,31 +2743,30 @@ first in that order decides alone: when its gate is shut there is no entry
|
||||
rather than the next subject's.
|
||||
|
||||
A frame places the eye `eye.upM` above `heightM` (the shared floor where the
|
||||
frame gives none, or the last height it had, the entry frame's included, while
|
||||
that floor is cold; with neither, the camera stays where it is and the HUD reads ACQUIRING SURFACE for
|
||||
frame gives none, or, while that floor is cold, the last height a frame gave,
|
||||
the entry frame's included; with neither, the camera stays where it is and the HUD reads ACQUIRING SURFACE for
|
||||
at most `COCKPIT_GROUND_WAIT_TIMEOUT_MS`, after which the view ends and the
|
||||
subject is released: no height stands in for a floor never read), slews toward `headingDeg` at the provider's rate, and may
|
||||
turn off the floor clamps (`groundClamp: false`, for a subject inside a
|
||||
structure) or keep the anchor exactly on the subject (`anchor: 'exact'`, for a
|
||||
layer that already moves it smoothly; a frame with no `speedMps` is always
|
||||
exact, since an inertial anchor runs on at the frame's speed); `cameraIntervalMs: 0` updates the
|
||||
camera every rendered frame. Each update turns, eases and moves the view by the
|
||||
time since the last one, so it keeps up when the browser draws few frames; an
|
||||
update more than a second past its interval (a hidden tab) moves it as one a
|
||||
second late would, and the update that first places the camera (after entry or
|
||||
a floor wait) stands its anchor on the subject. A frame that is null, malformed or for another
|
||||
camera every rendered frame. Each update turns the view, eases its lift and
|
||||
moves an inertial anchor by the time since the last one, at most a second past
|
||||
the interval (`cockpitSubjectStepSec`); an exact anchor stands where the frame
|
||||
is. The update that first places the camera (after entry or a floor wait)
|
||||
stands its anchor on the subject. A frame that is null, malformed or for another
|
||||
subject ends the view (`restoreTracking: false`), as an aircraft tracked
|
||||
meanwhile and the provider's layer turning off do; the exit control asks the
|
||||
provider to restore its subject. The generic HUD shows the provider's kicker,
|
||||
title, meta line, speed with its unit and tag, readout cards, always-visible
|
||||
source rows, banner, route card and Live Signals rows (each changes where it
|
||||
stands, its tone included, so a changing ETA never pushes a steady warning off
|
||||
the list; rows the view no longer lists leave before new ones come in), a veil that darkens the
|
||||
picture under the HUD (with passing light streaks, which stop under reduced
|
||||
motion), arrow-key look-around when the provider asks for it, and a progress
|
||||
source rows, banner, route card and Live Signals rows (each changes in place,
|
||||
its tone included, and keeps the time it first appeared; rows the view no
|
||||
longer lists leave before new ones come in), a veil that darkens the
|
||||
picture under the HUD (with passing light streaks, which stand still under
|
||||
reduced motion), arrow-key look-around when the provider asks for it, and a progress
|
||||
line along the bottom edge (`src/cockpitProgress.js`: close ticks merge,
|
||||
labels never overlap and get about 1 em for each full-width CJK, kana or Hangul
|
||||
glyph and a little more for an emoji or other astral glyph). Core translates none of the provider's text: a host
|
||||
labels never overlap and are sized for CJK and emoji glyphs). Core translates none of the provider's text: a host
|
||||
words it for the page's language (`gods-eye-view/i18n`:
|
||||
`getLocale`, `onLocaleChange`). Its entry face, labels and look may be
|
||||
functions, read again when they are shown and on a change of language, as the
|
||||
|
||||
Reference in new issue
Block a user