mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-06 03:14:00 +00:00
fix: preserve standalone overlay defaults for undefined overrides
This commit is contained in:
1 parent
4688eca9af
commit
106a794afa
2 files changed
+18
-2
No files matched your search
@@ -35,11 +35,15 @@ export const localGeoJsonServices = Object.freeze({
|
|||||||
export function createLocalGeoJsonLayer(options) {
|
export function createLocalGeoJsonLayer(options) {
|
||||||
return createLayer(options, {
|
return createLayer(options, {
|
||||||
...localGeoJsonServices,
|
...localGeoJsonServices,
|
||||||
overlayHost: options.overlayHost ?? localGeoJsonServices.overlayHost,
|
overlayHost: options.overlayHost === undefined
|
||||||
|
? localGeoJsonServices.overlayHost : options.overlayHost,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Create an overlay publisher using the standalone app's host by default. */
|
/** Create an overlay publisher using the standalone app's host by default. */
|
||||||
export function createLocalInfrastructureOverlayPublisher(options) {
|
export function createLocalInfrastructureOverlayPublisher(options) {
|
||||||
return createPublisher({ host: localGeoJsonServices.overlayHost, ...options });
|
return createPublisher({
|
||||||
|
...options,
|
||||||
|
host: options.host === undefined ? localGeoJsonServices.overlayHost : options.host,
|
||||||
|
});
|
||||||
}
|
}
|
||||||
@@ -1336,3 +1336,15 @@ test('globe-LOD re-selects during continuous motion, without ever seeing a moveE
|
|||||||
env.preRender.raise();
|
env.preRender.raise();
|
||||||
assert.deepEqual(env.layer.getLodDiagnostics(), parked, 'a parked camera never re-selects');
|
assert.deepEqual(env.layer.getLodDiagnostics(), parked, 'a parked camera never re-selects');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|
||||||
|
test('standalone publisher retains its default host for an undefined override', () => {
|
||||||
|
const publisher = createLocalInfrastructureOverlayPublisher({
|
||||||
|
sourceId: 'local-default-host-test', host: undefined,
|
||||||
|
});
|
||||||
|
assert.doesNotThrow(() => {
|
||||||
|
publisher.show();
|
||||||
|
publisher.hide();
|
||||||
|
publisher.destroy();
|
||||||
|
});
|
||||||
|
});
|
||||||
Reference in new issue
Block a user