fix: preserve standalone overlay defaults for undefined overrides

This commit is contained in:
Sameh Khamis committed 2026-09-11 13:32:49 -07:00
1 parent 4688eca9af
commit 106a794afa
2 files changed
+18 -2

No files matched your search

+6 -2
View File
@@ -35,11 +35,15 @@ export const localGeoJsonServices = Object.freeze({
export function createLocalGeoJsonLayer(options) { export function createLocalGeoJsonLayer(options) {
return createLayer(options, { return createLayer(options, {
...localGeoJsonServices, ...localGeoJsonServices,
overlayHost: options.overlayHost ?? localGeoJsonServices.overlayHost, overlayHost: options.overlayHost === undefined
? localGeoJsonServices.overlayHost : options.overlayHost,
}); });
} }
/** Create an overlay publisher using the standalone app's host by default. */ /** Create an overlay publisher using the standalone app's host by default. */
export function createLocalInfrastructureOverlayPublisher(options) { export function createLocalInfrastructureOverlayPublisher(options) {
return createPublisher({ host: localGeoJsonServices.overlayHost, ...options }); return createPublisher({
...options,
host: options.host === undefined ? localGeoJsonServices.overlayHost : options.host,
});
} }
+12
View File
@@ -1336,3 +1336,15 @@ test('globe-LOD re-selects during continuous motion, without ever seeing a moveE
env.preRender.raise(); env.preRender.raise();
assert.deepEqual(env.layer.getLodDiagnostics(), parked, 'a parked camera never re-selects'); assert.deepEqual(env.layer.getLodDiagnostics(), parked, 'a parked camera never re-selects');
}); });
test('standalone publisher retains its default host for an undefined override', () => {
const publisher = createLocalInfrastructureOverlayPublisher({
sourceId: 'local-default-host-test', host: undefined,
});
assert.doesNotThrow(() => {
publisher.show();
publisher.hide();
publisher.destroy();
});
});