mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-21 10:42:22 +00:00
Fix the review findings across the engines, layers, data and QA
Navara now matches Cesium where the review found it diverging: a flight holds the camera inputs, camera.changed counts turns as Cesium does, render requests made during a frame survive it, follow pinches zoom, ground widths follow the pixel ratio and Cyber sonar reaches glyph caches and models. On Cesium, a staged imagery swap keeps loading tiles, setView replaces a running flight, and a cleared weather detail goes away. The contract gains MoverSet.failed, maps.terrainRevision, render.maxTextureSize and surface.sampleTerrainMostDetailed on every engine, so layers retry failed models, key road heights by terrain, size weather textures to the GPU and place Bhote Koshi cards on detailed terrain. Engine switches keep the live view, follows, focus, layer options and cards: a pick hands over the exact pose, applies no address options and pans no carried-over card; a history visit still applies its entry. Layers put GhostMaps pins, cable landings, OSM Places and directions on the measured surface without per-frame sampling, draw the Cockpit contact dot, hide disabled CCTV on attach, and keep ALPR running outside secure contexts. KML imports draw raised polygon fills, rotated and coloured ground overlays and north-referenced icon headings, and report files with nothing to draw. QA scripts read the contract instead of Cesium internals (test:track is 109/109 again), wait for the camera to rest before clicking, and give cold switches and parked engines realistic time. Docs follow the code.
This commit is contained in:
1 parent
69fbf5b38d
commit
0ef29781e5
276 files changed
+7217
-1517
No files matched your search
@@ -0,0 +1,130 @@
|
||||
import test from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { DataLayerManager } from './manager.js';
|
||||
import { LAYER_STATE_REGISTRY, REGISTERED_LAYER_IDS } from './layerState.js';
|
||||
import { LayerStateCoordinator } from './layerStateCoordinator.js';
|
||||
|
||||
let windParamWrites = 0;
|
||||
function layer(id) {
|
||||
let params =
|
||||
id === 'wind'
|
||||
? { model: 'gfs', overlay: 'none', units: 'km/h', paused: false }
|
||||
: null;
|
||||
return {
|
||||
id,
|
||||
name: id,
|
||||
icon: '',
|
||||
source: 'test',
|
||||
async init() {
|
||||
return true;
|
||||
},
|
||||
async enable() {
|
||||
return true;
|
||||
},
|
||||
async update() {
|
||||
return true;
|
||||
},
|
||||
async disable() {
|
||||
return true;
|
||||
},
|
||||
attachRenderer() {},
|
||||
...(params
|
||||
? {
|
||||
setParams(next = {}) {
|
||||
windParamWrites++;
|
||||
params = { ...params, ...next };
|
||||
return true;
|
||||
},
|
||||
getParams() {
|
||||
return { ...params };
|
||||
},
|
||||
}
|
||||
: {}),
|
||||
};
|
||||
}
|
||||
function manager() {
|
||||
const m = new DataLayerManager({});
|
||||
for (const id of REGISTERED_LAYER_IDS) m.register(layer(id));
|
||||
m.finalizeRegistrations(LAYER_STATE_REGISTRY);
|
||||
return m;
|
||||
}
|
||||
const storage = () => {
|
||||
const v = new Map();
|
||||
return { getItem: (k) => v.get(k) ?? null, setItem: (k, x) => v.set(k, x) };
|
||||
};
|
||||
const sink = () => ({ setLayerStateProvider() {}, onLayerStateChange() {} });
|
||||
const cesiumEntry = {
|
||||
enabledLayerIds: ['wind'],
|
||||
options: { wind: { model: 'gfs' } },
|
||||
};
|
||||
|
||||
test('same-engine Back to a gfs entry restores gfs (reference)', async () => {
|
||||
const m = manager();
|
||||
const c = new LayerStateCoordinator(m, sink(), { storage: storage() });
|
||||
await m.setEnabled('wind', true, { origin: 'user' });
|
||||
m.setLayerParams('wind', { model: 'ifs' }, { origin: 'user' });
|
||||
assert.equal(m.getLayerParams('wind').model, 'ifs');
|
||||
await c.applyShareLayerState({ shareLayerState: cesiumEntry });
|
||||
assert.equal(m.getLayerParams('wind').model, 'gfs');
|
||||
});
|
||||
|
||||
const handoffOf = (m) =>
|
||||
new Map(
|
||||
[...m.layers].map(([id, entry]) => [
|
||||
id,
|
||||
{ entry, enabled: m.isEffectivelyEnabled(id), durable: id === 'wind' },
|
||||
]),
|
||||
);
|
||||
|
||||
test('cross-engine Back to a gfs entry restores gfs', async () => {
|
||||
const m = manager();
|
||||
await m.setEnabled('wind', true, { origin: 'user' });
|
||||
m.setLayerParams('wind', { model: 'ifs' }, { origin: 'user' });
|
||||
const handoffLayers = new Map(
|
||||
[...m.layers].map(([id, entry]) => [
|
||||
id,
|
||||
{
|
||||
entry,
|
||||
enabled: m.isEffectivelyEnabled(id),
|
||||
durable: id === 'wind',
|
||||
visit: true,
|
||||
},
|
||||
]),
|
||||
);
|
||||
const c = new LayerStateCoordinator(m, sink(), { storage: storage() });
|
||||
await c.start({ shareLayerState: cesiumEntry, handoffLayers });
|
||||
assert.equal(c.getDurableState().options.wind.model, 'gfs');
|
||||
assert.equal(
|
||||
m.getLayerParams('wind').model,
|
||||
'gfs',
|
||||
'live wind should follow the visited entry',
|
||||
);
|
||||
});
|
||||
|
||||
test('a picked engine keeps the live layer options, not the address', async () => {
|
||||
const m = manager();
|
||||
await m.setEnabled('wind', true, { origin: 'user' });
|
||||
m.setLayerParams('wind', { model: 'ifs' }, { origin: 'user' });
|
||||
const writes = windParamWrites;
|
||||
const c = new LayerStateCoordinator(m, sink(), { storage: storage() });
|
||||
await c.start({ shareLayerState: cesiumEntry, handoffLayers: handoffOf(m) });
|
||||
assert.equal(windParamWrites, writes, 'a pick writes no params');
|
||||
assert.equal(m.getLayerParams('wind').model, 'ifs');
|
||||
});
|
||||
|
||||
test('an engine switch leaves a retained layer whose options match alone', async () => {
|
||||
const m = manager();
|
||||
await m.setEnabled('wind', true, { origin: 'user' });
|
||||
m.setLayerParams('wind', { model: 'gfs' }, { origin: 'user' });
|
||||
const writes = windParamWrites;
|
||||
const c = new LayerStateCoordinator(m, sink(), { storage: storage() });
|
||||
const results = await c.start({
|
||||
shareLayerState: cesiumEntry,
|
||||
handoffLayers: handoffOf(m),
|
||||
});
|
||||
assert.equal(windParamWrites, writes, 'no params write for equal options');
|
||||
const wind = results.find((result) => result.layerId === 'wind');
|
||||
assert.equal(wind.phase, 'retained');
|
||||
assert.equal(wind.succeeded, true);
|
||||
assert.deepEqual(wind.appliedOptions, {});
|
||||
});
|
||||
Reference in new issue
Block a user