mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-17 00:32:21 +00:00
Idle frame rate in the app, timed line batching, KEY REQUIRED status
Three fixes to how the globe draws and reports loading. **The idle frame rate is the app's rule.** The Cesium frame port capped the loop at `IDLE_FRAME_RATE` whenever nothing held it, so the rule lived inside the renderer. The render governor now sets the rate: the display's own while the loop is held, `IDLE_FRAME_RATE` while not. The frame port gains `onHeldChange(cb)`, which says when its first hold is taken and its last released (animated visual styles included), so the governor hears every hold. The quality setting's frame-rate cap is kept apart from the governor's rate, and the loop draws at the lower of the two, so neither overwrites the other. **Line batching is timed.** A line set waited 30 drawn frames before its unchanged lines settled into a static batch (300 for the long wait), so the batch built twice as fast at 120 Hz as at 60 Hz, and took seconds at the idle rate. It now waits `SETTLE_MS` (500 ms) and `LONG_SETTLE_MS` (5 s), and moved shapes go back into their batches on the same timing. **KEY REQUIRED.** A layer that cannot load without a provider key ended the global status chip LOAD FAILED. The chip now has a KEY REQUIRED outcome, ranked below a real failure: a layer whose stats say `keyRequired` ends KEY REQUIRED, any other failure still ends LOAD FAILED. Vessels report a missing AISStream key as `keyRequired` and name the key in the panel; a later outage clears it, as it is no longer the key that is missing. Checked: the full suite (new tests for `onHeldChange`, the quality cap against the governor's rate, timed settling, and the chip with and without a key), format, boundaries, build, the stub renderer boot and the Cesium conformance run; in the browser, the idle and held frame rates; and the first-run check now asserts that with no keys set the chip never says LOAD FAILED.
This commit is contained in:
1 parent
84d3e7b5ce
commit
0ed6cde956
33 files changed
+629
-179
No files matched your search
+17
-14
@@ -12,11 +12,13 @@ north.
|
||||
|
||||
While anything moves (a layer in motion, the camera, a followed contact), the
|
||||
globe draws at the display's own refresh rate; there is no fixed 60 FPS cap.
|
||||
The Cesium frame port (`src/render/cesium/ports.js`, its `idleFps`) caps a
|
||||
parked scene at `IDLE_FRAME_RATE` (60, `src/renderGovernor.js`) ticks a
|
||||
second while no hold is out, because Cesium still runs the clock, data sources
|
||||
and update listeners on every animation frame even when it skips the draw; the
|
||||
viewer starts at that cap until the frame port takes over. Through the idle
|
||||
The render governor (`src/renderGovernor.js`) caps a parked scene at
|
||||
`IDLE_FRAME_RATE` (60) ticks a second while nothing holds the loop, because
|
||||
Cesium still runs the clock, data sources and update listeners on every
|
||||
animation frame even when it skips the draw, and lifts the cap while anything
|
||||
does: the frame port tells it when the loop's first hold is taken and its last
|
||||
released, its own holds (animated visual styles) included. The viewer starts
|
||||
at that cap until the governor is installed. Through the idle
|
||||
render governor, the camera port holds continuous render from `moveStart` to `moveEnd`, and samples its
|
||||
pose every 250 ms in between, so a camera drifting by rounding errors (no
|
||||
`moveEnd`) is released after half a second at rest and held again if it moves. The world clock holds continuous render while
|
||||
@@ -3809,10 +3811,10 @@ which embeds the MAP_KEY.
|
||||
> a layer that needs no key, already holds one, or names a key the registry does
|
||||
> not recognise. The earthquakes half
|
||||
> still delivers in full. The shared loading reducer now treats an explicitly
|
||||
> declared missing optional key as a configured terminal state rather than a
|
||||
> failed multi-layer mission, so the global chip completes without showing
|
||||
> `LOAD FAILED`. A genuine lifecycle or fetch failure still retains failure
|
||||
> priority.
|
||||
> declared missing optional key as its own terminal state rather than a
|
||||
> failed multi-layer mission, so the global chip ends `KEY REQUIRED` (amber)
|
||||
> instead of `LOAD FAILED`, on the first load and on every refresh. A genuine
|
||||
> lifecycle or fetch failure still retains failure priority.
|
||||
>
|
||||
> **Acceptance changed with that ruling (2026-08-23).** `qa-firstrun` no longer
|
||||
> asserts "a keyless Environmental never shows a failure chip" — that stopped
|
||||
@@ -4504,12 +4506,13 @@ down | auth-failed` (plus the unchanged `missing-key`/`unsupported`) with
|
||||
> specific error or availability state. The shared presentation is delayed to
|
||||
> avoid flashes, visible outside the rails, and retained in
|
||||
> Cockpit. One continuous overlapping load interval retains the strongest
|
||||
> terminal outcome (`failed`, then `cancelled`, then `complete`) until every
|
||||
> participant settles, so a later success cannot mask an earlier failure.
|
||||
> A participating producer's terminal error, unavailable status, or
|
||||
> key-required state also outranks generic completion without requiring a
|
||||
> terminal outcome (`failed`, then `key required`, then `cancelled`, then
|
||||
> `complete`) until every participant settles, so a later success cannot
|
||||
> mask an earlier failure. A participating producer's terminal error or
|
||||
> unavailable status also outranks generic completion without requiring a
|
||||
> separate manager failure event; AIS first-connect expiry therefore ends as
|
||||
> `LOAD FAILED`, not `LOAD COMPLETE`.
|
||||
> `LOAD FAILED`, not `LOAD COMPLETE`. A producer whose only problem is a
|
||||
> missing provider key (`stats.keyRequired`) ends the batch `KEY REQUIRED`.
|
||||
> Slow disable work is labeled as turning live data off rather than
|
||||
> as a completed load. Street Traffic's dedicated sync chip shows genuine
|
||||
> work and one bounded completion; steady TomTom coverage, including 0%, does
|
||||
|
||||
Reference in new issue
Block a user