mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
fix(transit): keep the real silhouettes under sensor presets, make the selected trail visible, put Transit in Movement (#596)
## Changes Follow-up to #587 after the owner's first look at the merged transit layer on Google 3D tiles. - **Sensor presets keep the real silhouettes.** Under NVG, thermal (white-hot, black-hot, Ironbow) and noir, vehicles are the same silhouettes as in normal view, filled opaque white with a 2 px dark halo, at the CRT display sizes (26 px fleet, 39 px selected). The solid rounded "signature" bodies are gone. - **The selected vehicle's trail is visible.** The retained history is now draped onto 3D tiles and terrain (`GroundPolylinePrimitive`, `ClassificationType.BOTH`, the way the traffic heat-lines are drawn), 3 px core over a 5 px dark backing, per-segment age colour, a short draped head clipped to the sprite. Two defects kept it off screen before: Cesium's per-instance attribute getters return copies, so the renderer's show/colour edits were discarded, and a marker did not recover after the camera jumped to it, which hid the trail with it. Trail geometry is now prepared on selection independent of floor resolution and marker visibility; sparse long intervals (rail) keep a bounded marker corridor instead of dropping the interval; classification survives map-source changes. - **Transit sits in the Movement panel group** between Street Traffic and Bike Share (the panel orders by `PANEL_GROUPS`, not by catalog order; the catalog is moved too). ## How it was verified - `npm run format:check` (854 files), `npm run check:boundaries`, `npm test` (4,062 passing), `npm run build` clean; tracking regression 109/109 in a real browser on Google 3D tiles. - Browser harness (`scripts/qa-transit.mjs`), keyed on Google 3D tiles and keyless: keyed 194 pass, with the trail pixel check passing at 300, 600 and 900 m; the remaining keyed failures are the per-frame allocation gate already recorded as a follow-up from #587 (CPU and frame time within budget), four readability lines at threshold edges, and the card-anchor check now counting frames where the selected marker is legitimately off screen; keyless 193 pass with the remaining misses being threshold edges on the thin tram silhouette (centre 0.83–0.88 against 0.85) and one bus ring 0.28 against 0.25 on a pure-white roof. - New harness checks: `Google 3D selected trail visible at 6 of 8 projected samples` (repeated off/on framebuffer captures at 300/600/900 m, samples outside the sprite footprint, a background-change negative control; fails on main, passes here), a camera-arrival check (select a moving vehicle, `setView` onto it, marker shown and trail body drawn within 2 s), `PANEL_ORDER` pinned, raster tests comparing every sensor raster's mask and aspect ratio to the normal silhouette. - Direct look on a keyed build: a live CapMetro bus at 30 m/s selected through the layer API draws its draped trail along the highway lane (harness capture `keyed-600m-trail-visible.jpg`). - Adversarial review by Codex Astra before the last two fix passes (stack-switch classification, marker corridor under the vertex cap, pixel-gate loophole), all three fixed with regressions. Docs: `docs/CURRENT-STATE.md` and `CHANGELOG.md` updated in this PR. No data-source changes.
This commit is contained in:
1 parent
cd22ca3559
commit
0bb61f53c6
24 files changed
+1945
-205
No files matched your search
@@ -328,3 +328,106 @@ test('trail-head acceptance names every missing and failed condition', async ()
|
||||
false,
|
||||
);
|
||||
});
|
||||
|
||||
const trailPatch = (rgb) =>
|
||||
Array.from({ length: 49 }, () => [...rgb, 255]).flat();
|
||||
const trailEvidence = (on, off) => ({
|
||||
onAgain: on,
|
||||
offAgain: off,
|
||||
tilesReady: true,
|
||||
samples: Array.from({ length: 8 }, (_, i) => ({
|
||||
x: i * 20 + 20,
|
||||
y: 20,
|
||||
radius: 3,
|
||||
inFront: true,
|
||||
})),
|
||||
sprite: { x: 300, y: 20, radius: 24 },
|
||||
});
|
||||
|
||||
test('trail pixels require repeatable contrast at six distinct samples outside the sprite', async () => {
|
||||
const { reduceTrailPixels } = await import('./qaMetrics.js');
|
||||
const off = Array.from({ length: 8 }, () => trailPatch([150, 150, 150]));
|
||||
const on = off.map((p, i) => (i < 6 ? trailPatch([94, 240, 138]) : p));
|
||||
const evidence = trailEvidence(on, off);
|
||||
assert.equal(reduceTrailPixels(on, off, evidence).pass, true);
|
||||
const five = on.map((p, i) => (i === 5 ? off[i] : p));
|
||||
assert.equal(
|
||||
reduceTrailPixels(five, off, trailEvidence(five, off)).pass,
|
||||
false,
|
||||
);
|
||||
for (const rgb of [
|
||||
[5, 8, 12],
|
||||
[126, 126, 126],
|
||||
]) {
|
||||
const patches = off.map(() => trailPatch(rgb));
|
||||
assert.equal(
|
||||
reduceTrailPixels(patches, off, trailEvidence(patches, off)).present,
|
||||
rgb[0] === 5 ? 8 : 0,
|
||||
);
|
||||
assert.equal(
|
||||
reduceTrailPixels(patches, patches, trailEvidence(patches, patches))
|
||||
.present,
|
||||
0,
|
||||
);
|
||||
}
|
||||
assert.equal(
|
||||
reduceTrailPixels(on, off).pass,
|
||||
false,
|
||||
'two reads are insufficient',
|
||||
);
|
||||
assert.equal(
|
||||
reduceTrailPixels(on, off, { ...evidence, tilesReady: false }).pass,
|
||||
false,
|
||||
);
|
||||
assert.equal(
|
||||
reduceTrailPixels(on, off, {
|
||||
...evidence,
|
||||
samples: Array(8).fill(evidence.samples[0]),
|
||||
}).pass,
|
||||
false,
|
||||
);
|
||||
assert.equal(
|
||||
reduceTrailPixels(on, off, {
|
||||
...evidence,
|
||||
sprite: { x: 80, y: 20, radius: 200 },
|
||||
}).pass,
|
||||
false,
|
||||
);
|
||||
assert.equal(reduceTrailPixels([], [], trailEvidence([], [])).pass, false);
|
||||
});
|
||||
|
||||
test('background refinement without a trail cannot pass repeated off/on acceptance', async () => {
|
||||
const { reduceTrailPixels } = await import('./qaMetrics.js');
|
||||
const grey = (n) => Array.from({ length: 8 }, () => trailPatch([n, n, n]));
|
||||
const off = grey(100),
|
||||
on = grey(30);
|
||||
const evidence = trailEvidence(on, off);
|
||||
assert.equal(
|
||||
reduceTrailPixels(on, off, { ...evidence, offAgain: grey(30) }).pass,
|
||||
false,
|
||||
'one background transition is not a trail',
|
||||
);
|
||||
assert.equal(
|
||||
reduceTrailPixels(on, off, {
|
||||
...evidence,
|
||||
offAgain: grey(170),
|
||||
onAgain: grey(100),
|
||||
}).pass,
|
||||
false,
|
||||
'equal deltas on a drifting baseline are not a trail',
|
||||
);
|
||||
assert.equal(
|
||||
reduceTrailPixels(on, off, { ...evidence, onAgain: off }).pass,
|
||||
false,
|
||||
'contrast must repeat',
|
||||
);
|
||||
const first = off.map((p) => p.map((v, i) => (i < 8 ? on[0][i] : v)));
|
||||
const second = off.map((p) =>
|
||||
p.map((v, i) => (i >= 8 && i < 16 ? on[0][i] : v)),
|
||||
);
|
||||
assert.equal(
|
||||
reduceTrailPixels(first, off, { ...evidence, onAgain: second }).pass,
|
||||
false,
|
||||
'the same pixels must change twice',
|
||||
);
|
||||
});
|
||||
Reference in new issue
Block a user