mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-17 16:52:20 +00:00
fix(transit): keep the real silhouettes under sensor presets, make the selected trail visible, put Transit in Movement (#596)
## Changes Follow-up to #587 after the owner's first look at the merged transit layer on Google 3D tiles. - **Sensor presets keep the real silhouettes.** Under NVG, thermal (white-hot, black-hot, Ironbow) and noir, vehicles are the same silhouettes as in normal view, filled opaque white with a 2 px dark halo, at the CRT display sizes (26 px fleet, 39 px selected). The solid rounded "signature" bodies are gone. - **The selected vehicle's trail is visible.** The retained history is now draped onto 3D tiles and terrain (`GroundPolylinePrimitive`, `ClassificationType.BOTH`, the way the traffic heat-lines are drawn), 3 px core over a 5 px dark backing, per-segment age colour, a short draped head clipped to the sprite. Two defects kept it off screen before: Cesium's per-instance attribute getters return copies, so the renderer's show/colour edits were discarded, and a marker did not recover after the camera jumped to it, which hid the trail with it. Trail geometry is now prepared on selection independent of floor resolution and marker visibility; sparse long intervals (rail) keep a bounded marker corridor instead of dropping the interval; classification survives map-source changes. - **Transit sits in the Movement panel group** between Street Traffic and Bike Share (the panel orders by `PANEL_GROUPS`, not by catalog order; the catalog is moved too). ## How it was verified - `npm run format:check` (854 files), `npm run check:boundaries`, `npm test` (4,062 passing), `npm run build` clean; tracking regression 109/109 in a real browser on Google 3D tiles. - Browser harness (`scripts/qa-transit.mjs`), keyed on Google 3D tiles and keyless: keyed 194 pass, with the trail pixel check passing at 300, 600 and 900 m; the remaining keyed failures are the per-frame allocation gate already recorded as a follow-up from #587 (CPU and frame time within budget), four readability lines at threshold edges, and the card-anchor check now counting frames where the selected marker is legitimately off screen; keyless 193 pass with the remaining misses being threshold edges on the thin tram silhouette (centre 0.83–0.88 against 0.85) and one bus ring 0.28 against 0.25 on a pure-white roof. - New harness checks: `Google 3D selected trail visible at 6 of 8 projected samples` (repeated off/on framebuffer captures at 300/600/900 m, samples outside the sprite footprint, a background-change negative control; fails on main, passes here), a camera-arrival check (select a moving vehicle, `setView` onto it, marker shown and trail body drawn within 2 s), `PANEL_ORDER` pinned, raster tests comparing every sensor raster's mask and aspect ratio to the normal silhouette. - Direct look on a keyed build: a live CapMetro bus at 30 m/s selected through the layer API draws its draped trail along the highway lane (harness capture `keyed-600m-trail-visible.jpg`). - Adversarial review by Codex Astra before the last two fix passes (stack-switch classification, marker corridor under the vertex cap, pixel-gate loophole), all three fixed with regressions. Docs: `docs/CURRENT-STATE.md` and `CHANGELOG.md` updated in this PR. No data-source changes.
This commit is contained in:
1 parent
cd22ca3559
commit
0bb61f53c6
24 files changed
+1945
-205
No files matched your search
@@ -329,3 +329,75 @@ export function reduceTrailHead(anchor, target) {
|
||||
selection: anchor?.selection ?? null,
|
||||
};
|
||||
}
|
||||
|
||||
/** Repeated off/on patches isolate stable, trail-correlated framebuffer changes. */
|
||||
export function reduceTrailPixels(on, off, evidence = {}) {
|
||||
const { onAgain, offAgain, samples = [], sprite, tilesReady } = evidence;
|
||||
const finitePoint = (p) =>
|
||||
p && [p.x, p.y, p.radius].every(Number.isFinite) && p.radius > 0;
|
||||
const stable = [],
|
||||
eligible = [];
|
||||
const hits = Array.from({ length: 8 }, (_, i) => {
|
||||
const point = samples[i];
|
||||
eligible[i] = !!(
|
||||
tilesReady === true &&
|
||||
finitePoint(point) &&
|
||||
point.inFront === true &&
|
||||
finitePoint(sprite) &&
|
||||
Math.hypot(point.x - sprite.x, point.y - sprite.y) >
|
||||
point.radius + sprite.radius &&
|
||||
samples
|
||||
.slice(0, i)
|
||||
.every(
|
||||
(prior) =>
|
||||
!finitePoint(prior) ||
|
||||
Math.hypot(point.x - prior.x, point.y - prior.y) >
|
||||
point.radius + prior.radius,
|
||||
)
|
||||
);
|
||||
const a = on?.[i],
|
||||
b = off?.[i],
|
||||
c = onAgain?.[i],
|
||||
d = offAgain?.[i];
|
||||
stable[i] = false;
|
||||
if (
|
||||
!eligible[i] ||
|
||||
!a?.length ||
|
||||
a.length % 4 ||
|
||||
[b, c, d].some((p) => !p || p.length !== a.length)
|
||||
)
|
||||
return false;
|
||||
let matches = 0;
|
||||
const contrast = (lit, baseline, k) => {
|
||||
const delta = Math.hypot(
|
||||
lit[k] - baseline[k],
|
||||
lit[k + 1] - baseline[k + 1],
|
||||
lit[k + 2] - baseline[k + 2],
|
||||
);
|
||||
const green = lit[k + 1] > lit[k] + 30 && lit[k + 1] > lit[k + 2] + 18;
|
||||
const dark =
|
||||
lit[k] + lit[k + 1] + lit[k + 2] <
|
||||
0.6 * (baseline[k] + baseline[k + 1] + baseline[k + 2]);
|
||||
return delta >= 40 && (green || dark);
|
||||
};
|
||||
for (let k = 0; k < a.length; k += 4) {
|
||||
for (let channel = 0; channel < 3; channel++) {
|
||||
const j = k + channel;
|
||||
if (
|
||||
![a[j], b[j], c[j], d[j]].every(
|
||||
(v) => Number.isFinite(v) && v >= 0 && v <= 255,
|
||||
) ||
|
||||
Math.abs(b[j] - d[j]) > 8 ||
|
||||
Math.abs(a[j] - c[j]) > 8 ||
|
||||
Math.abs(a[j] - b[j] - (c[j] - d[j])) > 8
|
||||
)
|
||||
return false;
|
||||
}
|
||||
if (contrast(a, b, k) && contrast(c, d, k)) matches++;
|
||||
}
|
||||
stable[i] = true;
|
||||
return matches >= 2;
|
||||
});
|
||||
const present = hits.filter(Boolean).length;
|
||||
return { hits, stable, eligible, present, total: 8, pass: present >= 6 };
|
||||
}
|
||||
Reference in new issue
Block a user