The renderer seam: clicks go to the newest tool, recession and display groups through the contract, drawing at parity with Cesium

- Clicks: when two tools want the globe's clicks, the newest takes them and the older is told and turns itself off; a click is decided when it arrives, and ambient selection fires only when no tool holds the pointer. The "map is busy" paths and their strings are removed.
- Recession: the limb fade is shared (src/render/recession.js) and reaches icon and model sets through SetSpec.recede; tuning applies on the next frame.
- Display panel groups are published through src/ui/displayGroups.js; the Weather group and src/viewWeather.js are removed.
- Draw port: a set whose icons only move is moved in place, and models that did not change are not restyled each frame, so moving fleets cost what they did when drawn directly; an untinted, fully opaque model is drawn without a colour.
- Conformance: input.lease.lost checks the new lease inside onLost and reports a throwing onLost; draw.sets.recede covers model sets.
- QA scripts read the renderer host instead of internals the seam replaced.
This commit is contained in:
Sameh Khamis committed 2026-11-15 17:03:09 -08:00
1 parent a0d299523d
commit 0ab31d4fb8
130 files changed
+5438 -1674

No files matched your search

+16 -17
View File
@@ -1,16 +1,13 @@
/**
* Box selection for the Recent Imagery layer: press on the world, drag, and
* release to hand the layer a degrees box. Follows the draw tool's ownership
* rules — the pointer is claimed for the session, the viewer's own click
* actions are suppressed and given back, and `destroy()` returns everything —
* and holds the camera only while a drag is in progress.
* rules — the pointer is claimed for the session (a newer claim cancels it),
* the viewer's own click actions are suppressed and given back, and
* `destroy()` returns everything — and holds the camera only while a drag is
* in progress.
*/
import { pickWorldFromScreen } from '../annotations/annotationResolver.js';
import {
claimPointer,
pointerOwner,
releasePointer,
} from '../data/inputOwnership.js';
import { claimPointer, releasePointer } from '../data/inputOwnership.js';
import { inputFor as defaultInputFor } from '../input/dispatcher.js';
import { validateBox } from '../layers/recentImagery/model.js';
import { createImageryBoxPreview } from '../layers/recentImagery/rendering.js';
@@ -154,14 +151,16 @@ export function initImageryBoxTool({
function setActive(next) {
if (next === active) return active;
if (next) {
lease = claimPointer(IMAGERY_BOX_POINTER_OWNER);
if (!lease) {
onCancel?.(
'pointer-busy',
`${pointerOwner()} is using the pointer — close it first`,
);
return active;
}
// The newest claim takes over: a tool holding the pointer is told and
// turns itself off, and a newer one cancels this session as if the
// person had.
const claimed = claimPointer(IMAGERY_BOX_POINTER_OWNER, {
onLost: () => {
if (lease === claimed) cancel();
},
});
if (!claimed) return active;
lease = claimed;
active = true;
bindScene();
} else {
@@ -182,7 +181,7 @@ export function initImageryBoxTool({
}
return {
/** Begin a box session. False when the pointer is held elsewhere. */
/** Begin a box session, taking the pointer from any tool holding it. */
start() {
return !destroyed && setActive(true);
},