mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
address the final review of the voice outline fixes
- A building word ("Burj Khalifa Tower", "Sagrada Familia Church") passes
the last-word rule on a building-like result; enclosures stay out.
- The anchor chooses only among the best-named outlines, so a worse name
never wins by containment alone.
- An ask without a quadrant takes only the quadrant of the matching street
nearest the point; a leading quadrant ("SE Main St") may go unsaid too.
- On an unbuffered tile edge a fragment shows as an edge along the
boundary, so a whole building touching it at a corner is not cut.
- Drop two orphaned comments and correct the place-name key wording.
This commit is contained in:
1 parent
a61d0f4c2a
commit
0712db9891
8 files changed
+194
-42
No files matched your search
@@ -217,6 +217,17 @@ test('grounds touching an unbuffered tile edge are cut, not complete', () => {
|
||||
const inside = decode([square(-179.999, 0, 0.01)]);
|
||||
assert.equal(inside.areas[0].clipped, false);
|
||||
assert.ok(enclosingAreaFromTiles([inside], ask));
|
||||
// A whole shape that only touches the edge at one corner is not cut.
|
||||
const tangent = decode([
|
||||
[
|
||||
[-180, 0.005],
|
||||
[-179.995, 0],
|
||||
[-179.99, 0.005],
|
||||
[-179.995, 0.01],
|
||||
[-180, 0.005],
|
||||
],
|
||||
]);
|
||||
assert.equal(tangent.areas[0].clipped, false);
|
||||
});
|
||||
|
||||
test('a point in a courtyard is not inside the building', () => {
|
||||
|
||||
Reference in new issue
Block a user