Read "from the map" after "please" is dropped

"hide flights from the map please" and "please clear everything except
flights from the map" read as they do without "please".

Co-authored-by: Manjunath Paparaju <[email protected]>
This commit is contained in:
Sameh KhamisandManjunath Paparaju committed 2026-11-18 19:33:50 -08:00
1 parent cd5a4443a2
commit 06eb60faab
2 files changed
+10 -8

No files matched your search

+8 -8
View File
@@ -292,13 +292,6 @@ export function normalizeLine(text, { isRequest = isPlainRequest } = {}) {
/^((?:turn|switch) (?:on|off)|show|hide|remove|enable|disable|clear|go to|fly to)\s+\1\b/i,
'$1',
);
// "remove flights from the map", "clear everything except ships from the
// map": the map is where every layer is. Not the verb's own "off" ("turn
// off the screen" is no layer switch).
line = line.replace(
/^((?:turn|switch) (?:on|off)|show|display|add|hide|remove|enable|disable|clear|toggle)\s+(\S.*?)\s+(?:from|off) (?:the )?(?:map|globe|screen|view)$/i,
'$1 $2',
);
// "please" is dropped only around a request: "Please Touch Museum",
// "Kindly Lane" and "Pretty Please" are names.
const polite = line
@@ -306,7 +299,14 @@ export function normalizeLine(text, { isRequest = isPlainRequest } = {}) {
.replace(/(?:\s*,\s*|\s+)(?:please|pls|plz)$/i, '')
.replace(end, '')
.trim();
return polite !== line && polite && isRequest(polite) ? polite : line;
const read = polite !== line && polite && isRequest(polite) ? polite : line;
// "remove flights from the map", "clear everything except ships from the
// map": the map is where every layer is. Not the verb's own "off" ("turn
// off the screen" is no layer switch).
return read.replace(
/^((?:turn|switch) (?:on|off)|show|display|add|hide|remove|enable|disable|clear|toggle)\s+(\S.*?)\s+(?:from|off) (?:the )?(?:map|globe|screen|view)$/i,
'$1 $2',
);
}
/** A request by its own words: a verb starting it, or a real question. */