mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
Merge branch 'main' into feat/voice-geometry
Picks up the Radio Next/Previous fix (#1474) and the Codespaces docs (#1515). The one conflict is the Radio cycle assertion in gevActions.test.mjs: main's new fallback flag is kept in this branch's layout.
This commit is contained in:
commit
05edae0606
31 files changed
+775
-170
No files matched your search
@@ -591,41 +591,50 @@ test('replacement input invalidates an in-flight Radio preflight immediately', (
|
||||
assert.equal(controller.radioHandoffEpoch, priorEpoch + 1);
|
||||
});
|
||||
|
||||
test('direct Radio pause or stop cancels a pending voice handoff', async () => {
|
||||
const order = [];
|
||||
let playbackControl = null;
|
||||
const ui = createTestVoiceUi();
|
||||
const controller = new GevRealtimeController({
|
||||
ui,
|
||||
runner: async () => ({ ok: true }),
|
||||
radioLayer: {
|
||||
subscribePlaybackControls(listener) {
|
||||
playbackControl = listener;
|
||||
return () => { playbackControl = null; };
|
||||
for (const [name, control, message] of [
|
||||
['direct Radio pause or stop cancels a pending voice handoff', 'stop', 'the explicit stop remains authoritative'],
|
||||
[
|
||||
'a direct Radio Next that does not play cancels a pending voice handoff',
|
||||
{ action: 'select', origin: 'user', attemptId: null },
|
||||
'the user selection is not overridden by voice playback',
|
||||
],
|
||||
]) {
|
||||
test(name, async () => {
|
||||
const order = [];
|
||||
let playbackControl = null;
|
||||
const ui = createTestVoiceUi();
|
||||
const controller = new GevRealtimeController({
|
||||
ui,
|
||||
runner: async () => ({ ok: true }),
|
||||
radioLayer: {
|
||||
subscribePlaybackControls(listener) {
|
||||
playbackControl = listener;
|
||||
return () => { playbackControl = null; };
|
||||
},
|
||||
playForVoice: async () => {
|
||||
order.push('radio-play');
|
||||
return true;
|
||||
},
|
||||
stopPlayback: () => order.push('radio-stop'),
|
||||
},
|
||||
playForVoice: async () => {
|
||||
order.push('radio-play');
|
||||
return true;
|
||||
},
|
||||
stopPlayback: () => order.push('radio-stop'),
|
||||
},
|
||||
});
|
||||
controller.debugLog = () => {};
|
||||
controller.dc = {
|
||||
readyState: 'open',
|
||||
send() {},
|
||||
close() { order.push('voice-stop'); },
|
||||
};
|
||||
controller.pendingRadioPlaybackResult = { ok: true, radioPlaybackRequested: true };
|
||||
});
|
||||
controller.debugLog = () => {};
|
||||
controller.dc = {
|
||||
readyState: 'open',
|
||||
send() {},
|
||||
close() { order.push('voice-stop'); },
|
||||
};
|
||||
controller.pendingRadioPlaybackResult = { ok: true, radioPlaybackRequested: true };
|
||||
|
||||
playbackControl('stop');
|
||||
await controller.handleRealtimeEvent({
|
||||
data: JSON.stringify({ type: 'response.done', response: { status: 'completed' } }),
|
||||
});
|
||||
playbackControl(control);
|
||||
await controller.handleRealtimeEvent({
|
||||
data: JSON.stringify({ type: 'response.done', response: { status: 'completed' } }),
|
||||
});
|
||||
|
||||
assert.equal(controller.pendingRadioPlaybackResult, null);
|
||||
assert.deepEqual(order, [], 'the explicit stop remains authoritative');
|
||||
});
|
||||
assert.equal(controller.pendingRadioPlaybackResult, null);
|
||||
assert.deepEqual(order, [], message);
|
||||
});
|
||||
}
|
||||
|
||||
test('confirmed manual Radio playback closes active voice without stopping Radio', () => {
|
||||
const order = [];
|
||||
|
||||
Reference in new issue
Block a user