Take "from the map" off after "clear" only when what is left clears the whole map

"clear all flights from the map" no longer offers to turn Flights on, and
"clear the layers from the map" clears the layers.

Co-authored-by: Manjunath Paparaju <[email protected]>
This commit is contained in:
Sameh KhamisandManjunath Paparaju committed 2026-11-18 20:38:56 -08:00
1 parent 3a5b10a1f6
commit 038915bc0b
3 files changed
+30 -14

No files matched your search

+12 -3
View File
@@ -304,11 +304,20 @@ export function normalizeLine(text, { isRequest = isPlainRequest } = {}) {
// map": the map is where every layer is taken from. Not the verb's own
// "off" ("turn off the screen" is no layer switch), not after "show"
// ("show me the view from the map" is a question), and after "clear"
// only for the whole map.
return read.replace(
/^((?:turn|switch) off|hide|remove|disable|clear(?= (?:everything|all|every)\b))\s+(\S.*?)\s+(?:from|off) (?:the )?(?:map|globe|screen|view)$/i,
// only for the whole map ("clear all flights" would read as a place).
const bare = read.replace(
/^((?:turn|switch) off|hide|remove|disable|clear)\s+(\S.*?)\s+(?:from|off) (?:the )?(?:map|globe|screen|view)$/i,
'$1 $2',
);
if (bare === read || !/^clear\b/i.test(bare)) return bare;
// "clear" takes the whole map: "clear flights" would read as a place.
const lower = bare.toLowerCase();
return CLEAR_ALL.test(lower) ||
/^clear (?:everything|all|every)\b.*\b(?:except|but|other than|apart from|besides|save for)\b/.test(
lower,
)
? bare
: read;
}
/** A request by its own words: a verb starting it, or a real question. */
+14 -7
View File
@@ -818,13 +818,19 @@ test('"except" leaves Satellites to switch off with Space Missions off', () => {
);
// "clear" takes the ending off only for the whole map: "clear flights
// from the map" never offers to turn Flights on.
assert.ok(
!omnibar
.rows('clear flights from the map', { places: [] })
.rows.some((row) =>
(row.steps || []).some((step) => step.kind === 'layer' && step.enabled),
),
);
for (const text of [
'clear flights from the map',
'clear all flights from the map',
])
assert.ok(
!omnibar
.rows(text, { places: [] })
.rows.some((row) =>
(row.steps || []).some(
(step) => step.kind === 'layer' && step.enabled,
),
),
);
// After "show" the ending is part of what is asked.
assert.equal(
omnibar.rows('show me the view from the map', { places: [] }).defaultIndex,
@@ -834,6 +840,7 @@ test('"except" leaves Satellites to switch off with Space Missions off', () => {
for (const text of [
'hide everything from the map',
'remove all layers from the map',
'clear the layers from the map',
]) {
const { rows } = omnibar.rows(text, { places: [] });
assert.equal(rows[0].kind, 'plan', text);