Settle the application's renderer through the shared Cesium ports

whenSettled moves from the conformance renderer into the shared Cesium
ports, unchanged but for what it waits for, and the application's renderer
gains it. A hidden globe loads nothing, so it no longer holds settling up:
the application hides its globe under photoreal tiles. Shown 3D tilesets in
the scene must have loaded what is in view, named 'tiles' while they have
not. Disposing the ports ends the watches under way, which fail as
destroyed, as the conformance renderer's destroy did.

It waits for the globe, the scene's tiles and what the draw sets hold, not
for what layers still draw through the viewer themselves.
This commit is contained in:
Sameh Khamis committed 2026-11-06 17:38:35 -08:00
1 parent 1a40c5a30a
commit 035276aa32
5 files changed
+212 -147

No files matched your search

+58
View File
@@ -712,3 +712,61 @@ test('setTime moves scene time and draws it, leaving the clock running or not',
assert.deepEqual(ports.frame.diagnostics().pendingReasons, ['time']);
ports.dispose();
});
test('whenSettled waits for shown 3D tiles, not for a hidden globe', async () => {
const { widget, scene, raise } = tickingWidget();
const list = [];
scene.primitives = listedPrimitives(list);
scene.globe = { show: false, tilesLoaded: false };
// Each asked-for frame is drawn soon after.
scene.requestRender = () => setTimeout(() => raise('postRender'), 1);
const ports = createCesiumPorts(widget, { capabilities: all });
const tileset = Object.create(Cesium.Cesium3DTileset.prototype);
Object.defineProperty(tileset, 'tilesLoaded', { value: false });
tileset.show = true;
list.push(tileset);
const result = await ports.whenSettled({ timeoutMs: 60 });
assert.equal(result.state, 'timeout');
assert.ok(result.blockers.includes('tiles'), result.blockers.join());
assert.ok(!result.blockers.includes('globe'), 'a hidden globe loads nothing');
tileset.show = false;
scene.globe.show = true;
const shown = await ports.whenSettled({ timeoutMs: 60 });
assert.ok(!shown.blockers.includes('tiles'), 'hidden tiles load nothing');
assert.ok(shown.blockers.includes('globe'), 'a shown globe still loading');
ports.dispose();
});
test('whenSettled under way fails as destroyed once the ports are disposed', async () => {
const { widget, scene, raise } = tickingWidget();
scene.primitives = listedPrimitives([]);
scene.requestRender = () => setTimeout(() => raise('postRender'), 1);
const ports = createCesiumPorts(widget, { capabilities: all });
const pending = ports.whenSettled({ timeoutMs: 5000 });
setTimeout(() => ports.dispose(), 5);
assert.deepEqual(await pending, { state: 'failed', blockers: ['destroyed'] });
});
test('whenSettled settles once shown tiles have loaded under a hidden globe', async () => {
const { widget, scene, raise } = tickingWidget();
const list = [];
scene.primitives = listedPrimitives(list);
scene.globe = { show: false, tilesLoaded: false };
scene.requestRender = () => setTimeout(() => raise('postRender'), 1);
const tileset = Object.create(Cesium.Cesium3DTileset.prototype);
Object.defineProperty(tileset, 'tilesLoaded', { value: true });
tileset.show = true;
list.push(tileset);
const ports = createCesiumPorts(widget, { capabilities: all });
// The loop ticks without drawing.
const ticker = setInterval(() => raise('preUpdate'), 5);
try {
assert.deepEqual(await ports.whenSettled({ timeoutMs: 2000 }), {
state: 'settled',
blockers: [],
});
} finally {
clearInterval(ticker);
ports.dispose();
}
});