mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-05 19:04:02 +00:00
i18n: fix review findings and polish ru/es strings
Fixes the 51 P0–P2 findings from the full review of the i18n branch and the issues found while checking every new string on screen in ru and es. - Translate errors and statuses that still reached ru/es in English: feed and tile errors, provider statuses, the ALPR chip, the traffic mode chip, voice plan step labels, fire feed values, receiver bands, scene save reasons and the Cesium attribution link. - Show preset city names in the UI language (src/ui/placeNames.js); data and everything sent to the model stay English. - Share layer names between the layer panel, HUD and voice card (src/ui/layerNames.js). - Keep long ru/es strings whole: voice card error lines, analyst titles, the voice tier status, the Nepal evidence button, the ALPR retry chip. English layout is unchanged. - Ask before a language switch drops unsaved work. - Catalog fixes: glossary terms (пуск, пресет), gender agreement and consistent "peticiones" in es, fewer calques in both languages. - Fix English text that was itself wrong (e.g. "Exit cockpit to fly to a weather", raw tool ids in voice plan steps). Catalogs: es/ru 2535 messages each, complete. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
1 parent
8029747b7e
commit
00704ddc89
212 files changed
+9871
-909
No files matched your search
@@ -0,0 +1,79 @@
|
||||
// Share-tracking restore notices are ready-made sentences per policy: a label
|
||||
// dropped into a template cannot take the case (ru) or article (es) the
|
||||
// sentence needs. English stays exactly as it was composed before.
|
||||
import { test } from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { setLocale } from '../i18n/index.js';
|
||||
import { SHARE_TRACKING_RESTORE_POLICIES } from '../data/layerState.js';
|
||||
import { shareTrackingRestoreNotice } from './shareRestoration.js';
|
||||
|
||||
const { flights, military, satellites } = SHARE_TRACKING_RESTORE_POLICIES;
|
||||
|
||||
test.afterEach(() => setLocale('en'));
|
||||
|
||||
test('en: the notices read as before for every policy and outcome', () => {
|
||||
setLocale('en');
|
||||
const notice = (policy, classification) =>
|
||||
shareTrackingRestoreNotice({ ...policy, classification });
|
||||
assert.equal(notice(flights, 'expired'), 'Shared flight follow expired');
|
||||
assert.equal(
|
||||
notice(military, 'expired'),
|
||||
'Shared military flight follow expired',
|
||||
);
|
||||
assert.equal(
|
||||
notice(satellites, 'source-unavailable'),
|
||||
'Shared satellite could not be restored — feed unavailable',
|
||||
);
|
||||
assert.equal(
|
||||
notice(flights, 'source-unavailable'),
|
||||
'Shared flight could not be restored — feed unavailable',
|
||||
);
|
||||
assert.equal(
|
||||
notice(military, 'unavailable'),
|
||||
'Shared military flight is unavailable',
|
||||
);
|
||||
assert.equal(
|
||||
notice(satellites, 'unavailable'),
|
||||
'Shared satellite is unavailable',
|
||||
);
|
||||
// Unknown label and classification: the generic template still applies.
|
||||
assert.equal(
|
||||
shareTrackingRestoreNotice({ label: 'contact', classification: 'odd' }),
|
||||
'Shared contact is unavailable',
|
||||
);
|
||||
assert.equal(
|
||||
shareTrackingRestoreNotice({ classification: 'expired' }),
|
||||
'Shared entity follow expired',
|
||||
);
|
||||
});
|
||||
|
||||
test('ru: the restore notices do not glue the nominative label into a genitive slot', () => {
|
||||
setLocale('ru');
|
||||
for (const policy of [flights, military, satellites]) {
|
||||
for (const classification of [
|
||||
'expired',
|
||||
'source-unavailable',
|
||||
'unavailable',
|
||||
]) {
|
||||
const message = shareTrackingRestoreNotice({ ...policy, classification });
|
||||
// "Срок отслеживания" takes the genitive: рейса / спутника, never the
|
||||
// nominative label as stored in the policy.
|
||||
assert.doesNotMatch(
|
||||
message,
|
||||
/отслеживания (военный )?(рейс|спутник) /,
|
||||
message,
|
||||
);
|
||||
assert.doesNotMatch(message, /Shared|\{subject\}/, message);
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
test('es: the restore notices read with an article before the subject', () => {
|
||||
setLocale('es');
|
||||
const message = shareTrackingRestoreNotice({
|
||||
...flights,
|
||||
classification: 'expired',
|
||||
});
|
||||
assert.doesNotMatch(message, /seguimiento de vuelo/, message);
|
||||
assert.doesNotMatch(message, /Shared/, message);
|
||||
});
|
||||
Reference in new issue
Block a user