mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
i18n: fix review findings and polish ru/es strings
Fixes the 51 P0–P2 findings from the full review of the i18n branch and the issues found while checking every new string on screen in ru and es. - Translate errors and statuses that still reached ru/es in English: feed and tile errors, provider statuses, the ALPR chip, the traffic mode chip, voice plan step labels, fire feed values, receiver bands, scene save reasons and the Cesium attribution link. - Show preset city names in the UI language (src/ui/placeNames.js); data and everything sent to the model stay English. - Share layer names between the layer panel, HUD and voice card (src/ui/layerNames.js). - Keep long ru/es strings whole: voice card error lines, analyst titles, the voice tier status, the Nepal evidence button, the ALPR retry chip. English layout is unchanged. - Ask before a language switch drops unsaved work. - Catalog fixes: glossary terms (пуск, пресет), gender agreement and consistent "peticiones" in es, fewer calques in both languages. - Fix English text that was itself wrong (e.g. "Exit cockpit to fly to a weather", raw tool ids in voice plan steps). Catalogs: es/ru 2535 messages each, complete. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
1 parent
8029747b7e
commit
00704ddc89
212 files changed
+9871
-909
No files matched your search
@@ -0,0 +1,82 @@
|
||||
// Preset place names show in the UI language at the presentation boundary
|
||||
// (voice results, location pills, HUD); the preset data stays English.
|
||||
import { test } from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { setLocale } from '../i18n/index.js';
|
||||
import { CITY_POIS } from '../locations.js';
|
||||
import { KNOWN_PLACE_NAMES, localizePlaceName } from './placeNames.js';
|
||||
import { LocationControls } from './locationControls.js';
|
||||
|
||||
test.afterEach(() => setLocale('en'));
|
||||
|
||||
test('every preset city has a display name entry', () => {
|
||||
for (const city of Object.values(CITY_POIS))
|
||||
assert.ok(KNOWN_PLACE_NAMES.includes(city.name), city.name);
|
||||
});
|
||||
|
||||
test('en: place names pass through unchanged', () => {
|
||||
setLocale('en');
|
||||
for (const name of KNOWN_PLACE_NAMES)
|
||||
assert.equal(localizePlaceName(name), name);
|
||||
});
|
||||
|
||||
for (const [locale, tokyo, losAngeles] of [
|
||||
['ru', 'Токио', 'Лос-Анджелес'],
|
||||
['es', 'Tokio', 'Los Ángeles'],
|
||||
]) {
|
||||
test(`${locale}: preset names are translated, other places shown as given`, () => {
|
||||
setLocale(locale);
|
||||
assert.equal(localizePlaceName('Tokyo'), tokyo);
|
||||
assert.equal(localizePlaceName('Los Angeles'), losAngeles);
|
||||
assert.equal(localizePlaceName('Ulaanbaatar'), 'Ulaanbaatar');
|
||||
assert.equal(localizePlaceName(undefined), undefined);
|
||||
});
|
||||
}
|
||||
|
||||
function element() {
|
||||
return {
|
||||
children: [],
|
||||
dataset: {},
|
||||
textContent: '',
|
||||
addEventListener() {},
|
||||
removeEventListener() {},
|
||||
appendChild(child) {
|
||||
this.children.push(child);
|
||||
},
|
||||
replaceChildren() {
|
||||
this.children = [];
|
||||
},
|
||||
};
|
||||
}
|
||||
|
||||
test('ru: location pills and the mini-status show the translated city', () => {
|
||||
setLocale('ru');
|
||||
const elements = {
|
||||
pills: element(),
|
||||
poiRow: element(),
|
||||
divider: element(),
|
||||
search: element(),
|
||||
searchToggle: element(),
|
||||
resetButtons: [],
|
||||
statusCity: element(),
|
||||
statusPoi: element(),
|
||||
};
|
||||
const doc = { ...element(), createElement: element };
|
||||
const cities = { tokyo: CITY_POIS.tokyo };
|
||||
const controls = new LocationControls({
|
||||
elements,
|
||||
cities,
|
||||
getExpandedCity: () => null,
|
||||
onCity() {},
|
||||
onPoi() {},
|
||||
onSearch() {},
|
||||
onReset() {},
|
||||
doc,
|
||||
requestFrame: () => 0,
|
||||
cancelFrame() {},
|
||||
});
|
||||
assert.equal(elements.pills.children[0].textContent, 'Токио');
|
||||
controls.renderStatus({ city: CITY_POIS.tokyo, currentPoi: null });
|
||||
assert.equal(elements.statusCity.textContent, '📍 Токио');
|
||||
assert.equal(CITY_POIS.tokyo.name, 'Tokyo');
|
||||
});
|
||||
Reference in new issue
Block a user