mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-05 02:44:02 +00:00
i18n: fix review findings and polish ru/es strings
Fixes the 51 P0–P2 findings from the full review of the i18n branch and the issues found while checking every new string on screen in ru and es. - Translate errors and statuses that still reached ru/es in English: feed and tile errors, provider statuses, the ALPR chip, the traffic mode chip, voice plan step labels, fire feed values, receiver bands, scene save reasons and the Cesium attribution link. - Show preset city names in the UI language (src/ui/placeNames.js); data and everything sent to the model stay English. - Share layer names between the layer panel, HUD and voice card (src/ui/layerNames.js). - Keep long ru/es strings whole: voice card error lines, analyst titles, the voice tier status, the Nepal evidence button, the ALPR retry chip. English layout is unchanged. - Ask before a language switch drops unsaved work. - Catalog fixes: glossary terms (пуск, пресет), gender agreement and consistent "peticiones" in es, fewer calques in both languages. - Fix English text that was itself wrong (e.g. "Exit cockpit to fly to a weather", raw tool ids in voice plan steps). Catalogs: es/ru 2535 messages each, complete. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
1 parent
8029747b7e
commit
00704ddc89
212 files changed
+9871
-909
No files matched your search
@@ -0,0 +1,142 @@
|
||||
// K-27: the dock language switch reloads the page, so it asks first while the
|
||||
// reload would lose work (unsaved CCTV calibration, the open cockpit, anything
|
||||
// a module registers).
|
||||
import { test } from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { StyleManager } from './applicationShell.js';
|
||||
import {
|
||||
describeUnsavedWork,
|
||||
msg,
|
||||
registerUnsavedWork,
|
||||
setLocale,
|
||||
} from '../i18n/index.js';
|
||||
|
||||
function fakeButton() {
|
||||
const listeners = {};
|
||||
return {
|
||||
dataset: {},
|
||||
classList: { toggle() {} },
|
||||
setAttribute() {},
|
||||
addEventListener: (type, listener) => (listeners[type] = listener),
|
||||
click: () => listeners.click(),
|
||||
};
|
||||
}
|
||||
|
||||
/** Render the switch into a fake dock with the given shell state. */
|
||||
function renderSwitch({ calDirty = false, cockpit = false } = {}) {
|
||||
const buttons = [];
|
||||
const previous = {
|
||||
document: globalThis.document,
|
||||
location: globalThis.location,
|
||||
history: globalThis.history,
|
||||
confirm: globalThis.confirm,
|
||||
};
|
||||
const reloads = [];
|
||||
const prompts = [];
|
||||
let answer = true;
|
||||
globalThis.document = {
|
||||
querySelector: () => ({ appendChild: (button) => buttons.push(button) }),
|
||||
createElement: fakeButton,
|
||||
};
|
||||
globalThis.location = {
|
||||
href: 'https://gev.example/#v=2',
|
||||
assign() {},
|
||||
reload: () => reloads.push(true),
|
||||
};
|
||||
globalThis.history = { replaceState() {} };
|
||||
globalThis.confirm = (text) => {
|
||||
prompts.push(text);
|
||||
return answer;
|
||||
};
|
||||
const shell = {
|
||||
services: {
|
||||
cctvLayer: {
|
||||
getUIState: () => ({ cameras: [{ calDirty: false }, { calDirty }] }),
|
||||
},
|
||||
},
|
||||
cockpitView: { active: cockpit },
|
||||
_confirmLocaleReload: StyleManager.prototype._confirmLocaleReload,
|
||||
};
|
||||
StyleManager.prototype._initLocaleSelector.call(shell);
|
||||
const button = (locale) =>
|
||||
buttons.find((candidate) => candidate.dataset.locale === locale);
|
||||
return {
|
||||
button,
|
||||
reloads,
|
||||
prompts,
|
||||
answer: (value) => (answer = value),
|
||||
restore() {
|
||||
for (const unregister of shell._unsavedWorkChecks) unregister();
|
||||
Object.assign(globalThis, previous);
|
||||
},
|
||||
};
|
||||
}
|
||||
|
||||
const storage = globalThis.localStorage;
|
||||
test.before(() => {
|
||||
globalThis.localStorage = { setItem() {}, getItem: () => null };
|
||||
});
|
||||
test.after(() => {
|
||||
globalThis.localStorage = storage;
|
||||
});
|
||||
|
||||
test('nothing to lose: the switch reloads without asking', () => {
|
||||
const view = renderSwitch();
|
||||
try {
|
||||
view.button('es').click();
|
||||
assert.deepEqual(view.prompts, []);
|
||||
assert.equal(view.reloads.length, 1);
|
||||
} finally {
|
||||
view.restore();
|
||||
}
|
||||
});
|
||||
|
||||
test('unsaved calibration or the open cockpit: the switch asks first', () => {
|
||||
const view = renderSwitch({ calDirty: true, cockpit: true });
|
||||
try {
|
||||
view.answer(false);
|
||||
view.button('ru').click();
|
||||
assert.equal(view.prompts.length, 1);
|
||||
assert.match(view.prompts[0], /unsaved CCTV calibration/);
|
||||
assert.match(view.prompts[0], /the open cockpit/);
|
||||
assert.equal(view.reloads.length, 0, 'declined: no reload');
|
||||
view.answer(true);
|
||||
view.button('ru').click();
|
||||
assert.equal(view.reloads.length, 1, 'confirmed: reload');
|
||||
} finally {
|
||||
view.restore();
|
||||
}
|
||||
});
|
||||
|
||||
test('modules register their own unsaved work', () => {
|
||||
const unregister = registerUnsavedWork(() => msg('drawings on the map'));
|
||||
const failing = registerUnsavedWork(() => {
|
||||
throw new Error('broken check');
|
||||
});
|
||||
const view = renderSwitch();
|
||||
try {
|
||||
view.answer(false);
|
||||
view.button('es').click();
|
||||
assert.match(view.prompts[0], /drawings on the map/);
|
||||
assert.equal(view.reloads.length, 0);
|
||||
} finally {
|
||||
view.restore();
|
||||
unregister();
|
||||
failing();
|
||||
}
|
||||
assert.deepEqual(describeUnsavedWork(), []);
|
||||
});
|
||||
|
||||
test('the prompt reads in the active language', () => {
|
||||
setLocale('es');
|
||||
const view = renderSwitch({ calDirty: true });
|
||||
try {
|
||||
view.answer(false);
|
||||
view.button('en').click();
|
||||
assert.equal(view.prompts.length, 1);
|
||||
assert.doesNotMatch(view.prompts[0], /Switching language/);
|
||||
} finally {
|
||||
view.restore();
|
||||
setLocale('en');
|
||||
}
|
||||
});
|
||||
Reference in new issue
Block a user