mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-05 10:53:59 +00:00
i18n: fix review findings and polish ru/es strings
Fixes the 51 P0–P2 findings from the full review of the i18n branch and the issues found while checking every new string on screen in ru and es. - Translate errors and statuses that still reached ru/es in English: feed and tile errors, provider statuses, the ALPR chip, the traffic mode chip, voice plan step labels, fire feed values, receiver bands, scene save reasons and the Cesium attribution link. - Show preset city names in the UI language (src/ui/placeNames.js); data and everything sent to the model stay English. - Share layer names between the layer panel, HUD and voice card (src/ui/layerNames.js). - Keep long ru/es strings whole: voice card error lines, analyst titles, the voice tier status, the Nepal evidence button, the ALPR retry chip. English layout is unchanged. - Ask before a language switch drops unsaved work. - Catalog fixes: glossary terms (пуск, пресет), gender agreement and consistent "peticiones" in es, fewer calques in both languages. - Fix English text that was itself wrong (e.g. "Exit cockpit to fly to a weather", raw tool ids in voice plan steps). Catalogs: es/ru 2535 messages each, complete. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
1 parent
8029747b7e
commit
00704ddc89
212 files changed
+9871
-909
No files matched your search
@@ -0,0 +1,77 @@
|
||||
// K-22: a copied share link must not carry the sender's ?lang override: on the
|
||||
// recipient's side ?lang would beat their own stored choice.
|
||||
import { test } from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { ShareLinkManager } from './sharelink.js';
|
||||
import { resolveLocale } from './i18n/locale.js';
|
||||
import { persistLocaleAndReload } from './i18n/index.js';
|
||||
|
||||
function makeManager(href) {
|
||||
globalThis.window = { location: { href, hash: new URL(href).hash } };
|
||||
globalThis.history = { replaceState() {} };
|
||||
const viewer = {
|
||||
camera: {
|
||||
changed: { addEventListener() {} },
|
||||
positionCartographic: { latitude: 0, longitude: 0, height: 1000 },
|
||||
heading: 0,
|
||||
pitch: -Math.PI / 2,
|
||||
roll: 0,
|
||||
},
|
||||
};
|
||||
return new ShareLinkManager(viewer);
|
||||
}
|
||||
|
||||
function installClipboard(writeText) {
|
||||
Object.defineProperty(globalThis, 'navigator', {
|
||||
configurable: true,
|
||||
value: { clipboard: { writeText } },
|
||||
});
|
||||
}
|
||||
|
||||
test('K-22: the copied link does not carry the sender ?lang override', async () => {
|
||||
let copied = null;
|
||||
installClipboard(async (url) => {
|
||||
copied = url;
|
||||
});
|
||||
const manager = makeManager('https://gev.example/?lang=ru#v=2&lat=10&lon=20');
|
||||
assert.equal(await manager.copyLink({ nowMs: 1_000_000 }), true);
|
||||
const link = new URL(copied);
|
||||
assert.equal(link.searchParams.get('lang'), null, `copied link: ${copied}`);
|
||||
|
||||
// Why it matters: on the recipient's side ?lang beats the stored choice and
|
||||
// the browser language.
|
||||
const store = new Map([['gev:locale:v1', 'es']]);
|
||||
const recipient = resolveLocale({
|
||||
location: { search: link.search },
|
||||
storage: { getItem: (k) => store.get(k) ?? null },
|
||||
languages: ['en-US'],
|
||||
});
|
||||
assert.equal(recipient, 'es');
|
||||
});
|
||||
|
||||
test('K-22: with storage blocked the dock switch keeps the choice in ?lang', () => {
|
||||
let href = 'https://gev.example/#v=2';
|
||||
const location = {
|
||||
get href() {
|
||||
return href;
|
||||
},
|
||||
assign(next) {
|
||||
href = next;
|
||||
},
|
||||
reload() {},
|
||||
};
|
||||
const history = {
|
||||
replaceState: (_s, _t, url) => {
|
||||
href = url;
|
||||
},
|
||||
};
|
||||
const blocked = {
|
||||
setItem() {
|
||||
throw new Error('blocked');
|
||||
},
|
||||
};
|
||||
persistLocaleAndReload('ru', { location, history, storage: blocked });
|
||||
// Documented behaviour (persistLocaleAndReload): the choice survives only in
|
||||
// the URL, which is why copyLink has to drop it.
|
||||
assert.equal(new URL(href).searchParams.get('lang'), 'ru');
|
||||
});
|
||||
Reference in new issue
Block a user